Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2444383009: Delete deprecated method VideoFrame::CreateFrame. (Closed)

Created:
4 years, 1 month ago by nisse-webrtc
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete deprecated method VideoFrame::CreateFrame. BUG=webrtc:6591 Committed: https://crrev.com/f0a7c5ac16752e3408f551162cb3aad8a7864e78 Cr-Commit-Position: refs/heads/master@{#14849}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -122 lines) Patch
M webrtc/common_video/i420_video_frame_unittest.cc View 2 chunks +16 lines, -42 lines 0 comments Download
M webrtc/common_video/video_frame.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M webrtc/test/frame_generator.cc View 2 chunks +11 lines, -9 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/video_frame.h View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
nisse-webrtc
No external use, as far as I've been able to determine.
4 years, 1 month ago (2016-10-27 12:09:42 UTC) #2
magjed_webrtc
lgtm
4 years, 1 month ago (2016-10-27 13:25:25 UTC) #3
stefan-webrtc
lgtm
4 years, 1 month ago (2016-10-31 10:59:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2444383009/1
4 years, 1 month ago (2016-10-31 11:42:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 12:48:09 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 12:48:23 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f0a7c5ac16752e3408f551162cb3aad8a7864e78
Cr-Commit-Position: refs/heads/master@{#14849}

Powered by Google App Engine
This is Rietveld 408576698