Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Side by Side Diff: webrtc/modules/video_coding/frame_object.h

Issue 2444193010: Delete FrameObject::size member. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 18 matching lines...) Expand all
29 29
30 // The capture timestamp of this frame. 30 // The capture timestamp of this frame.
31 virtual uint32_t Timestamp() const = 0; 31 virtual uint32_t Timestamp() const = 0;
32 32
33 // When this frame was received. 33 // When this frame was received.
34 virtual int64_t ReceivedTime() const = 0; 34 virtual int64_t ReceivedTime() const = 0;
35 35
36 // When this frame should be rendered. 36 // When this frame should be rendered.
37 virtual int64_t RenderTime() const = 0; 37 virtual int64_t RenderTime() const = 0;
38 38
39 size_t size() { return _length; }
nisse-webrtc 2016/10/27 11:24:34 It should be _length here, not _size, right?
philipel 2016/10/27 11:27:15 Thats right!
sprang_webrtc 2016/10/27 12:40:02 Ugh.. Any chance you could rename them size_ and c
39 40
40 // The tuple (|picture_id|, |spatial_layer|) uniquely identifies a frame 41 // The tuple (|picture_id|, |spatial_layer|) uniquely identifies a frame
41 // object. For codec types that don't necessarily have picture ids they 42 // object. For codec types that don't necessarily have picture ids they
42 // have to be constructed from the header data relevant to that codec. 43 // have to be constructed from the header data relevant to that codec.
43 uint16_t picture_id; 44 uint16_t picture_id;
44 uint8_t spatial_layer; 45 uint8_t spatial_layer;
45 uint32_t timestamp; 46 uint32_t timestamp;
46 47
47 size_t num_references; 48 size_t num_references;
48 uint16_t references[kMaxFrameReferences]; 49 uint16_t references[kMaxFrameReferences];
49 bool inter_layer_predicted; 50 bool inter_layer_predicted;
50
51 size_t size;
52 }; 51 };
53 52
54 class PacketBuffer; 53 class PacketBuffer;
55 54
56 class RtpFrameObject : public FrameObject { 55 class RtpFrameObject : public FrameObject {
57 public: 56 public:
58 RtpFrameObject(PacketBuffer* packet_buffer, 57 RtpFrameObject(PacketBuffer* packet_buffer,
59 uint16_t first_seq_num, 58 uint16_t first_seq_num,
60 uint16_t last_seq_num, 59 uint16_t last_seq_num,
61 size_t frame_size, 60 size_t frame_size,
(...skipping 23 matching lines...) Expand all
85 84
86 // Equal to times nacked of the packet with the highet times nacked 85 // Equal to times nacked of the packet with the highet times nacked
87 // belonging to this frame. 86 // belonging to this frame.
88 int times_nacked_; 87 int times_nacked_;
89 }; 88 };
90 89
91 } // namespace video_coding 90 } // namespace video_coding
92 } // namespace webrtc 91 } // namespace webrtc
93 92
94 #endif // WEBRTC_MODULES_VIDEO_CODING_FRAME_OBJECT_H_ 93 #endif // WEBRTC_MODULES_VIDEO_CODING_FRAME_OBJECT_H_
OLDNEW
« no previous file with comments | « webrtc/modules/video_coding/frame_buffer2.cc ('k') | webrtc/modules/video_coding/frame_object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698