webrtc/media/engine/fakewebrtccall.cc - Issue 2443123002: Delete ShallowCopy, in favor of copy construction and assignment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/engine/fakewebrtccall.cc

Issue 2443123002: Delete ShallowCopy, in favor of copy construction and assignment. (Closed)

Patch Set: Rebase. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/media/engine/fakewebrtccall.cc

diff --git a/webrtc/media/engine/fakewebrtccall.cc b/webrtc/media/engine/fakewebrtccall.cc

index a25fe541ab894c23b37d299a6808f3957c35ce5f..df6febe734effbe8e61733f56888df817c2a0398 100644

--- a/webrtc/media/engine/fakewebrtccall.cc

+++ b/webrtc/media/engine/fakewebrtccall.cc

@@ -178,7 +178,7 @@ void FakeVideoSendStream::OnFrame(const webrtc::VideoFrame& frame) {

video_streams_ = encoder_config_.video_stream_factory->CreateEncoderStreams(

frame.width(), frame.height(), encoder_config_);

}

- last_frame_.ShallowCopy(frame);

+ last_frame_ = frame;

}

void FakeVideoSendStream::SetStats(