Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/common_video/video_frame.cc

Issue 2443123002: Delete ShallowCopy, in favor of copy construction and assignment. (Closed)
Patch Set: Renamed method argument. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/common_video/i420_video_frame_unittest.cc ('k') | webrtc/media/engine/fakewebrtccall.cc » ('j') | webrtc/modules/video_processing/test/video_processing_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/common_video/video_frame.cc
diff --git a/webrtc/common_video/video_frame.cc b/webrtc/common_video/video_frame.cc
index 7145a623e65ef4837c7b216b528ae1575254506a..b85241035157f71207f923d93f34d24f791da459 100644
--- a/webrtc/common_video/video_frame.cc
+++ b/webrtc/common_video/video_frame.cc
@@ -93,12 +93,8 @@ void VideoFrame::CreateFrame(const uint8_t* buffer,
stride_uv, stride_uv, rotation);
}
-void VideoFrame::ShallowCopy(const VideoFrame& videoFrame) {
- video_frame_buffer_ = videoFrame.video_frame_buffer();
- timestamp_rtp_ = videoFrame.timestamp_rtp_;
- ntp_time_ms_ = videoFrame.ntp_time_ms_;
- timestamp_us_ = videoFrame.timestamp_us_;
- rotation_ = videoFrame.rotation_;
+void VideoFrame::ShallowCopy(const VideoFrame& frame) {
+ *this = frame;
}
int VideoFrame::width() const {
« no previous file with comments | « webrtc/common_video/i420_video_frame_unittest.cc ('k') | webrtc/media/engine/fakewebrtccall.cc » ('j') | webrtc/modules/video_processing/test/video_processing_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698