Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2442813002: Fix more swarming test failures by using fake clock. (Closed)

Created:
4 years, 2 months ago by honghaiz3
Modified:
4 years, 1 month ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix more swarming test failures by using the fake clock or longer timeout. In the swarming test, the machines sometimes were blocked for 1-2 seconds without processing anything. This CL makes sure that 1 second timeout is only used with fake clock. BUG=webrtc:6500 Committed: https://crrev.com/e58d73d23ea7d3338c3b4617943224f9c71a2612 Cr-Commit-Position: refs/heads/master@{#14756}

Patch Set 1 : . #

Total comments: 1

Patch Set 2 : Advance the clock by 1 second to avoid test failure due to assumptions on non-zero actual time valu… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -83 lines) Patch
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 1 33 chunks +116 lines, -82 lines 0 comments Download
M webrtc/p2p/base/port.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 21 (14 generated)
honghaiz3
https://codereview.chromium.org/2442813002/diff/20001/webrtc/p2p/base/port.cc File webrtc/p2p/base/port.cc (right): https://codereview.chromium.org/2442813002/diff/20001/webrtc/p2p/base/port.cc#newcode928 webrtc/p2p/base/port.cc:928: bool receiving = This prevents incorrect evaluation of receiving ...
4 years, 1 month ago (2016-10-24 18:56:38 UTC) #3
pthatcher1
lgtm
4 years, 1 month ago (2016-10-24 20:14:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2442813002/20001
4 years, 1 month ago (2016-10-24 20:29:40 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_x64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/18912)
4 years, 1 month ago (2016-10-24 20:38:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2442813002/60001
4 years, 1 month ago (2016-10-24 23:36:32 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 1 month ago (2016-10-24 23:38:29 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 23:38:34 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e58d73d23ea7d3338c3b4617943224f9c71a2612
Cr-Commit-Position: refs/heads/master@{#14756}

Powered by Google App Engine
This is Rietveld 408576698