Remove LOGGING=1 define.

Remove LOGGING=1 define.

The LOGGING define is only used in a single location in our whole codebase:
$ git gs "f LOGGING"
webrtc/base/physicalsocketserver.cc:1584:#if LOGGING
$ git gs "defined(LOGGING"
(no hits)

The above commands also give no hits in Chromium's code base.

BUG=webrtc:6412
NOTRY=True

Committed: https://crrev.com/a101e560b990b8e9ca0d37672c55a532e6d2ec51
Cr-Commit-Position: refs/heads/master@{#14799}

[kjellander_webrtc, 2016-10-24 07:39:45]

Description was changed from

==========
Remove LOGGING=1 define.

The LOGGING define is only used in a single location in our whole codebase:
$ git gs "f LOGGING"
webrtc/base/physicalsocketserver.cc:1584:#if LOGGING
$ git gs "defined(LOGGING"
(no hits)

BUG=None
==========

to

==========
Remove LOGGING=1 define.

The LOGGING define is only used in a single location in our whole codebase:
$ git gs "f LOGGING"
webrtc/base/physicalsocketserver.cc:1584:#if LOGGING
$ git gs "defined(LOGGING"
(no hits)

The above commands also give no hits in Chromium's code base.

BUG=None
==========

[kjellander_webrtc, 2016-10-24 07:40:33]

Patchset #2 (id:20001) has been deleted

[kjellander_webrtc, 2016-10-24 07:40:39]

The CQ bit was checked by kjellander@webrtc.org to run a CQ dry run

[kjellander_webrtc, 2016-10-24 07:40:43]

The CQ bit was checked by kjellander@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 07:40:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-24 07:41:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 07:41:59]

Dry run: Try jobs failed on following builders:
  ios32_sim_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/11769)
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/14119)
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/19358)

[kjellander_webrtc, 2016-10-24 07:46:08]

Description was changed from

==========
Remove LOGGING=1 define.

The LOGGING define is only used in a single location in our whole codebase:
$ git gs "f LOGGING"
webrtc/base/physicalsocketserver.cc:1584:#if LOGGING
$ git gs "defined(LOGGING"
(no hits)

The above commands also give no hits in Chromium's code base.

BUG=None
==========

to

==========
Remove LOGGING=1 define.

The LOGGING define is only used in a single location in our whole codebase:
$ git gs "f LOGGING"
webrtc/base/physicalsocketserver.cc:1584:#if LOGGING
$ git gs "defined(LOGGING"
(no hits)

The above commands also give no hits in Chromium's code base.

BUG=None
NOTRY=True
==========

[kjellander_webrtc, 2016-10-26 11:05:50]

Description was changed from

==========
Remove LOGGING=1 define.

The LOGGING define is only used in a single location in our whole codebase:
$ git gs "f LOGGING"
webrtc/base/physicalsocketserver.cc:1584:#if LOGGING
$ git gs "defined(LOGGING"
(no hits)

The above commands also give no hits in Chromium's code base.

BUG=None
NOTRY=True
==========

to

==========
Remove LOGGING=1 define.

The LOGGING define is only used in a single location in our whole codebase:
$ git gs "f LOGGING"
webrtc/base/physicalsocketserver.cc:1584:#if LOGGING
$ git gs "defined(LOGGING"
(no hits)

The above commands also give no hits in Chromium's code base.

BUG=webrtc:6412
NOTRY=True
==========

[kjellander_webrtc, 2016-10-26 11:06:46]

Patchset #3 (id:60001) has been deleted

[kjellander_webrtc, 2016-10-26 11:07:42]

kjellander@webrtc.org changed reviewers:
+ deadbeef@webrtc.org

[kjellander_webrtc, 2016-10-26 11:07:43]

We should be able to remove this, right?

[Taylor Brandstetter, 2016-10-26 21:18:57]

lgtm

[kjellander_webrtc, 2016-10-27 09:17:26]

On 2016/10/26 21:18:57, Taylor Brandstetter wrote:
> lgtm

Compilation passed on the Chromium trybots I ran but they're having some
infrastructure problems. I think we're safe to land.

[kjellander_webrtc, 2016-10-27 09:18:33]

kjellander@webrtc.org changed reviewers:
+ perkj@webrtc.org

[kjellander_webrtc, 2016-10-27 09:18:34]

+perkj for owners approval

[perkj_webrtc, 2016-10-27 09:31:46]

lgtm

[kjellander_webrtc, 2016-10-27 09:33:07]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-10-27 09:33:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-27 09:34:33]

Description was changed from

==========
Remove LOGGING=1 define.

The LOGGING define is only used in a single location in our whole codebase:
$ git gs "f LOGGING"
webrtc/base/physicalsocketserver.cc:1584:#if LOGGING
$ git gs "defined(LOGGING"
(no hits)

The above commands also give no hits in Chromium's code base.

BUG=webrtc:6412
NOTRY=True
==========

to

==========
Remove LOGGING=1 define.

The LOGGING define is only used in a single location in our whole codebase:
$ git gs "f LOGGING"
webrtc/base/physicalsocketserver.cc:1584:#if LOGGING
$ git gs "defined(LOGGING"
(no hits)

The above commands also give no hits in Chromium's code base.

BUG=webrtc:6412
NOTRY=True
==========

[commit-bot: I haz the power, 2016-10-27 09:34:35]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-10-27 09:34:48]

Description was changed from

==========
Remove LOGGING=1 define.

The LOGGING define is only used in a single location in our whole codebase:
$ git gs "f LOGGING"
webrtc/base/physicalsocketserver.cc:1584:#if LOGGING
$ git gs "defined(LOGGING"
(no hits)

The above commands also give no hits in Chromium's code base.

BUG=webrtc:6412
NOTRY=True
==========

to

==========
Remove LOGGING=1 define.

The LOGGING define is only used in a single location in our whole codebase:
$ git gs "f LOGGING"
webrtc/base/physicalsocketserver.cc:1584:#if LOGGING
$ git gs "defined(LOGGING"
(no hits)

The above commands also give no hits in Chromium's code base.

BUG=webrtc:6412
NOTRY=True

Committed: https://crrev.com/a101e560b990b8e9ca0d37672c55a532e6d2ec51
Cr-Commit-Position: refs/heads/master@{#14799}
==========

[commit-bot: I haz the power, 2016-10-27 09:34:49]

Patchset 2 (id:??) landed as
https://crrev.com/a101e560b990b8e9ca0d37672c55a532e6d2ec51
Cr-Commit-Position: refs/heads/master@{#14799}