Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2442123002: [LayoutNG] Remove one NGConstraintSpace constructor, mark others for removal. (Closed)

Created:
4 years, 2 months ago by ikilpatrick
Modified:
4 years, 2 months ago
Reviewers:
Gleb Lanbin, eae
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Remove one NGConstraintSpace constructor, mark others for removal. Once the builder is added only the: NGConstraintSpace(NGWritingMode, NGDirection, NGPhysicalConstraintSpace*) should remain, this mirrors the NGFragment constructor which is just a "view" on top of the NGPhysicalFragment. This mirrors: NGFragment(NGWritingMode, NGDirection, NGPhysicalFragment*) BUG=635619 Committed: https://crrev.com/ce86bdc2a63e021733d86af975d0ce47e38ec935 Cr-Commit-Position: refs/heads/master@{#426995}

Patch Set 1 #

Patch Set 2 : rebase \o;/ #

Patch Set 3 : remove silly comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -25 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_box.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h View 1 2 2 chunks +7 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc View 1 2 chunks +4 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 27 (17 generated)
ikilpatrick
4 years, 2 months ago (2016-10-21 22:52:12 UTC) #4
Gleb Lanbin
lgtm
4 years, 2 months ago (2016-10-21 23:21:22 UTC) #5
eae
I like it, LGTM
4 years, 2 months ago (2016-10-22 00:17:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442123002/1
4 years, 2 months ago (2016-10-22 00:17:52 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/321858)
4 years, 2 months ago (2016-10-22 02:58:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442123002/1
4 years, 2 months ago (2016-10-22 07:04:38 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/287439)
4 years, 2 months ago (2016-10-22 07:24:09 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442123002/40001
4 years, 2 months ago (2016-10-22 16:54:56 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-23 13:39:45 UTC) #25
commit-bot: I haz the power
4 years, 2 months ago (2016-10-23 13:42:02 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ce86bdc2a63e021733d86af975d0ce47e38ec935
Cr-Commit-Position: refs/heads/master@{#426995}

Powered by Google App Engine
This is Rietveld 408576698