RTCStats equality operator added

webrtc/stats/rtcstats_unittest.cc

 /*
  *  Copyright 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 95 matching lines @@
 
   int32_t numbers[] = { 4, 8, 15, 16, 23, 42 };
   std::vector<int32_t> numbers_sequence(&numbers[0], &numbers[6]);
   stats.m_sequence_int32->clear();
   stats.m_sequence_int32->insert(stats.m_sequence_int32->end(),
                                  numbers_sequence.begin(),
                                  numbers_sequence.end());
   EXPECT_EQ(*stats.m_sequence_int32, numbers_sequence);
 }
 
+TEST(RTCStatsTest, EqualityOperator) {
+  RTCTestStats undefined("testId", 123);
+  EXPECT_EQ(undefined, undefined);
+
+  RTCTestStats defined = undefined;
+  defined.m_bool = true;
+  defined.m_int32 = 123;
+  defined.m_uint32 = 123;
+  defined.m_int64 = 123;
+  defined.m_uint64 = 123;
+  defined.m_double = 123.0;
+  defined.m_string = "123";
+  defined.m_sequence_bool = std::vector<bool>();
+  defined.m_sequence_int32 = std::vector<int32_t>();
+  defined.m_sequence_uint32 = std::vector<uint32_t>();
+  defined.m_sequence_int64 = std::vector<int64_t>();
+  defined.m_sequence_uint64 = std::vector<uint64_t>();
+  defined.m_sequence_double = std::vector<double>();
+  defined.m_sequence_string = std::vector<std::string>();
+  EXPECT_NE(defined, undefined);
+  EXPECT_EQ(defined, defined);
+  EXPECT_NE(defined.m_int32, defined.m_uint32);
+
+  RTCTestStats diffs[] = {
+    defined, defined, defined, defined, defined, defined, defined, defined,
+    defined, defined, defined, defined, defined, defined,
+  };
+  for (size_t i = 0; i < 14; ++i) {
+    EXPECT_EQ(defined, diffs[i]);
+  }
+  diffs[0].m_bool = false;
+  diffs[1].m_int32 = 321;
+  diffs[2].m_uint32 = 321;
+  diffs[3].m_int64 = 321;
+  diffs[4].m_uint64 = 321;
+  diffs[5].m_double = 321.0;
+  diffs[6].m_string = "321";
+  diffs[7].m_sequence_bool->push_back(false);
+  diffs[8].m_sequence_int32->push_back(321);
+  diffs[9].m_sequence_uint32->push_back(321);
+  diffs[10].m_sequence_int64->push_back(321);
+  diffs[11].m_sequence_uint64->push_back(321);
+  diffs[12].m_sequence_double->push_back(321.0);
+  diffs[13].m_sequence_string->push_back("321");
+  for (size_t i = 0; i < 14; ++i) {
+    EXPECT_NE(defined, diffs[i]);
+  }
+
+  RTCTestStats undefined_diff_id("testId2", 123);

[hta-webrtc, 2016/10/25 10:30:30]

"undefined" is a very poor name, because it looks like a reserved word (is so in
many other languages).
what about "undefined" -> "empty_stats" and "defined" ->
"stats_with_all_values"?

also _diff_ -> _different_ for clarity.

[hbos, 2016/10/25 10:49:41]

Done.

+  EXPECT_NE(undefined, undefined_diff_id);
+  RTCTestStats undefined_diff_timestamp("testId", 321);
+  EXPECT_NE(undefined, undefined_diff_timestamp);
+
+  RTCChildStats child("childId", 42);
+  RTCGrandChildStats grandchild("grandchildId", 42);
+  EXPECT_NE(child, grandchild);
+}
+
 TEST(RTCStatsTest, RTCStatsGrandChild) {
   RTCGrandChildStats stats("grandchild", 0.0);
   stats.child_int = 1;
   stats.grandchild_int = 2;
   int32_t sum = 0;
   for (const RTCStatsMemberInterface* member : stats.Members()) {
     sum += *member->cast_to<const RTCStatsMember<int32_t>>();
   }
   EXPECT_EQ(sum, static_cast<int32_t>(3));
 
@@ skipping 15 matching lines @@
 }
 
 TEST(RTCStatsDeathTest, InvalidCasting) {
   RTCGrandChildStats stats("grandchild", 0.0);
   EXPECT_DEATH(stats.cast_to<RTCChildStats>(), "");
 }
 
 #endif  // RTC_DCHECK_IS_ON && GTEST_HAS_DEATH_TEST && !defined(WEBRTC_ANDROID)
 
 }  // namespace webrtc