Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2441493003: Revert of Delete unused file mediacommon.h. (Closed)

Created:
4 years, 2 months ago by nisse-webrtc
Modified:
4 years, 2 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, pthatcher1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Delete unused file mediacommon.h. (patchset #1 id:1 of https://codereview.webrtc.org/2437703002/ ) Reason for revert: Turned out this broke a downstream app. Reverting while investigating. Original issue's description: > Delete unused file mediacommon.h. > > BUG=None > > Committed: https://crrev.com/a34e796a1b59a1068c77a3e36d2a24fd37c08afc > Cr-Commit-Position: refs/heads/master@{#14689} TBR=magjed@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/ca20e7cfed301982986a4da23c819b4e50b5a6e9 Cr-Commit-Position: refs/heads/master@{#14697}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M webrtc/media/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A webrtc/media/base/mediacommon.h View 1 chunk +27 lines, -0 lines 0 comments Download
M webrtc/media/base/mediaengine.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/media.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nisse-webrtc
Created Revert of Delete unused file mediacommon.h.
4 years, 2 months ago (2016-10-20 09:52:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2441493003/1
4 years, 2 months ago (2016-10-20 09:52:52 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 09:53:02 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ca20e7cfed301982986a4da23c819b4e50b5a6e9 Cr-Commit-Position: refs/heads/master@{#14697}
4 years, 2 months ago (2016-10-20 09:53:12 UTC) #6
nisse-webrtc
4 years, 2 months ago (2016-10-21 06:56:59 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2426393006/ by nisse@webrtc.org.

The reason for reverting is: #include of mediacommon.h now deleted in the
offending downstream app..

Powered by Google App Engine
This is Rietveld 408576698