GN: New conventions, default target and refactorings

webrtc/tools/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("//third_party/protobuf/proto_library.gni")
 import("../build/webrtc.gni")
 
 group("tools") {
-  deps = [
+  # This target shall build all targets in tools/.
+  testonly = true
+
+  public_deps = [
     ":command_line_parser",
+    ":frame_analyzer",
+    ":frame_editor",
+    ":psnr_ssim_analyzer",
+    ":rgba_to_i420_converter",
   ]
+  if (rtc_include_internal_audio_device) {
+    public_deps += [ ":force_mic_volume_max" ]
+  }
+  if (rtc_enable_protobuf) {
+    public_deps += [ ":chart_proto" ]
+  }
 
-  if (!build_with_chromium) {
-    # TODO(kjellander): Enable these when webrtc:5970 is fixed.
-    deps += [
-      ":frame_analyzer",
-      ":rgba_to_i420_converter",
+  if (rtc_include_tests) {
+    public_deps += [
+      ":activity_metric",
+      ":rtp_analyzer",
+      ":tools_unittests",
     ]
+    if (rtc_enable_protobuf) {
+      public_deps += [ ":event_log_visualizer" ]
+    }
   }
 }
 
 rtc_static_library("command_line_parser") {
   sources = [
     "simple_command_line_parser.cc",
     "simple_command_line_parser.h",
   ]
   deps = [
     "../base:gtest_prod",
@@ skipping 89 matching lines @@
     sources = [
       "force_mic_volume_max/force_mic_volume_max.cc",
     ]
 
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
 
     deps = [
-      "../modules/audio_device:audio_device",
+      "../modules/audio_device",
       "../system_wrappers:system_wrappers_default",
       "//build/win:default_exe_manifest",
     ]
   }
 }
 
 if (rtc_enable_protobuf) {
   proto_library("chart_proto") {
     sources = [
       "event_log_visualizer/chart.proto",
@@ skipping 13 matching lines @@
       "event_log_visualizer/plot_python.h",
     ]
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
     defines = [ "ENABLE_RTC_EVENT_LOG" ]
     deps = [
       "../logging:rtc_event_log_impl",
       "../logging:rtc_event_log_parser",
-      "../modules/congestion_controller:congestion_controller",
-      "../modules/rtp_rtcp:rtp_rtcp",
+      "../modules/congestion_controller",
+      "../modules/rtp_rtcp",
       "../system_wrappers:system_wrappers_default",
       "//build/config/sanitizers:deps",
     ]
     public_deps = [
       ":chart_proto",
       "../logging:rtc_event_log_parser",
     ]
   }
 }
 
@@ skipping 96 matching lines @@
       ]
       outputs = [
         "$root_build_dir/{{source_file_part}}",
       ]
       deps = [
         "../logging:rtc_event_log_proto",
       ]
     }
   }
 }