Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2440703002:
Android VideoFileRenderer: Wait for posted frames in release() (Closed)
|
Created:
4 years, 2 months ago by magjed_webrtc Modified:
4 years, 2 months ago Reviewers:
sakal CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAndroid VideoFileRenderer: Wait for posted frames in release()
We need to wait for posted frames to be rendered first in release()
instead of abruptly quitting, in order to simplify testing.
BUG=webrtc:6545
R=sakal@webrtc.org
Committed: https://crrev.com/894c400c61db94e3f7bdb2a9e9bbbce40dd1da86
Cr-Commit-Position: refs/heads/master@{#14722}
Patch Set 1 #
Messages
Total messages: 17 (9 generated)
Description was changed from ========== Android VideoFileRenderer: Wait for posted frames in release() We need to wait for posted frames to be rendered first in release() instead of abruptly quitting, in order to simplify testing. BUG=webrtc:6545 ========== to ========== Android VideoFileRenderer: Wait for posted frames in release() We need to wait for posted frames to be rendered first in release() instead of abruptly quitting, in order to simplify testing. BUG=webrtc:6545 ==========
magjed@webrtc.org changed reviewers: + sakal@webrtc.org
Sami - please take a look.
lgtm
The CQ bit was checked by magjed@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_clang_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_compile_mips_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_compile_x64_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_compile_x86_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_compile_x86_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_gyp_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_arm on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_asan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_compile_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_gyp_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_libfuzzer_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_msan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_tsan2 on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_ubsan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_ubsan_vptr on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) presubmit on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by magjed@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_asan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) presubmit on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by magjed@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Description was changed from ========== Android VideoFileRenderer: Wait for posted frames in release() We need to wait for posted frames to be rendered first in release() instead of abruptly quitting, in order to simplify testing. BUG=webrtc:6545 ========== to ========== Android VideoFileRenderer: Wait for posted frames in release() We need to wait for posted frames to be rendered first in release() instead of abruptly quitting, in order to simplify testing. BUG=webrtc:6545 R=sakal@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/894c400c61db94e3f7bdb2a9e... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 894c400c61db94e3f7bdb2a9e9bbbce40dd1da86 (presubmit successful).
Message was sent while issue was closed.
Description was changed from ========== Android VideoFileRenderer: Wait for posted frames in release() We need to wait for posted frames to be rendered first in release() instead of abruptly quitting, in order to simplify testing. BUG=webrtc:6545 R=sakal@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/894c400c61db94e3f7bdb2a9e... ========== to ========== Android VideoFileRenderer: Wait for posted frames in release() We need to wait for posted frames to be rendered first in release() instead of abruptly quitting, in order to simplify testing. BUG=webrtc:6545 R=sakal@webrtc.org Committed: https://crrev.com/894c400c61db94e3f7bdb2a9e9bbbce40dd1da86 Cr-Commit-Position: refs/heads/master@{#14722} ========== |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
