Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 2440613002: A variable in ScreenCapturerWinDirectx has a bad name (Closed)

Created:
4 years, 2 months ago by Hzj_jie
Modified:
4 years, 2 months ago
Reviewers:
Sergey Ulanov
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

A variable in ScreenCapturerWinDirectx has a bad name BUG=https://bugs.chromium.org/p/chromium/issues/detail?id=314516 Committed: https://crrev.com/79f0bf3ab52f65770de89c7cae3a6e0ab4f04223 Cr-Commit-Position: refs/heads/master@{#14686}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M webrtc/modules/desktop_capture/win/screen_capturer_win_directx.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/desktop_capture/win/screen_capturer_win_directx.cc View 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Hzj_jie
4 years, 2 months ago (2016-10-19 22:21:27 UTC) #3
Sergey Ulanov
lgtm
4 years, 2 months ago (2016-10-19 22:42:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2440613002/1
4 years, 2 months ago (2016-10-19 23:04:17 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_clang_dbg on ...
4 years, 2 months ago (2016-10-19 23:51:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2440613002/1
4 years, 2 months ago (2016-10-20 04:38:44 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 06:40:39 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-20 06:40:51 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/79f0bf3ab52f65770de89c7cae3a6e0ab4f04223
Cr-Commit-Position: refs/heads/master@{#14686}

Powered by Google App Engine
This is Rietveld 408576698