Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2440433002: Fix org.mockito.Matchers deprecation warnings in DirectRTCClientTest. (Closed)

Created:
4 years, 2 months ago by sakal
Modified:
4 years, 2 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix org.mockito.Matchers deprecation warnings in DirectRTCClientTest. ArgumentMatchers is the new name of the class. Also, we don't need to pass a class to the isNotNull matcher. BUG=webrtc:6558 R=magjed@webrtc.org Committed: https://crrev.com/5f70d3b5597bbca81b18b5807e12209500286d61 Cr-Commit-Position: refs/heads/master@{#14706}

Patch Set 1 #

Patch Set 2 : New isNotNull requires Java 8. Suppress deprecation warnings instead. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M webrtc/examples/androidjunit/src/org/appspot/apprtc/DirectRTCClientTest.java View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
sakal
PTAL
4 years, 2 months ago (2016-10-19 14:16:31 UTC) #1
magjed_webrtc
lgtm
4 years, 2 months ago (2016-10-19 14:44:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2440433002/1
4 years, 2 months ago (2016-10-19 14:47:00 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_clang_dbg on ...
4 years, 2 months ago (2016-10-19 16:47:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2440433002/1
4 years, 2 months ago (2016-10-20 08:35:18 UTC) #8
sakal
Apparently the new isNotNull requires Java 8 which the bots don't support. PTAL
4 years, 2 months ago (2016-10-20 08:43:12 UTC) #9
magjed_webrtc
lgtm
4 years, 2 months ago (2016-10-20 08:55:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2440433002/20001
4 years, 2 months ago (2016-10-20 09:54:21 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_drmemory_light on master.tryserver.webrtc (JOB_FAILED, no build URL)
4 years, 2 months ago (2016-10-20 11:02:02 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2440433002/20001
4 years, 2 months ago (2016-10-20 12:06:02 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-20 12:49:12 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-10-20 13:06:54 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5f70d3b5597bbca81b18b5807e12209500286d61
Cr-Commit-Position: refs/heads/master@{#14706}

Powered by Google App Engine
This is Rietveld 408576698