Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2440353003: Remove unused function implementations from FakeWebRtcVoiceEngine. (Closed)

Created:
4 years, 1 month ago by the sun
Modified:
4 years, 1 month ago
Reviewers:
minyue
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unused function implementations from FakeWebRtcVoiceEngine. BUG=webrtc:4690 Committed: https://crrev.com/88b70747451a41a1d0f8dc607c959ce8548d83cb Cr-Commit-Position: refs/heads/master@{#14752}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -113 lines) Patch
M webrtc/media/engine/fakewebrtcvoiceengine.h View 6 chunks +10 lines, -113 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
the sun
4 years, 1 month ago (2016-10-24 14:58:28 UTC) #2
minyue
lgtm
4 years, 1 month ago (2016-10-24 18:48:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2440353003/1
4 years, 1 month ago (2016-10-24 20:06:55 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 20:46:04 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 20:46:11 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88b70747451a41a1d0f8dc607c959ce8548d83cb
Cr-Commit-Position: refs/heads/master@{#14752}

Powered by Google App Engine
This is Rietveld 408576698