Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 2440123002: Revert of H264 codec: Check profile-level-id when matching (Closed)

Created:
4 years, 2 months ago by magjed_webrtc
Modified:
4 years, 1 month ago
Reviewers:
kthelgason, hta-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of H264 codec: Check profile-level-id when matching (patchset #2 id:60001 of https://codereview.webrtc.org/2347863003/ ) Reason for revert: Breaks H264 for external encoders in WebRTC as well as breaking H264 interop with e.g. Edge. Original issue's description: > H264 codec: Check profile-level-id when matching > > For the H264 video codec, comparing the codec name is not enough > for determining a match. The profile-level-id must also match. > This CL: > - Specializes the VideoCodec::Matches function with extra logic for > matching H264 codecs. > - Adds unittests for matching H264 video codecs. > - Removes the unnecessary CodecTest fixture class. > > BUG=webrtc:6337, chromium:645599 > > Committed: https://crrev.com/68979ab7dd971ab6e983b23c83154ba05e183fb8 > Cr-Commit-Position: refs/heads/master@{#14546} TBR=kthelgason@webrtc.org,hta@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6337, chromium:645599, webrtc:6552, webrtc:6402 Committed: https://crrev.com/06c8e1eaa7eb35c519c499f1d22d718213f71cc0 Cr-Commit-Position: refs/heads/master@{#14759}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -121 lines) Patch
M webrtc/media/base/codec.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/media/base/codec.cc View 1 2 chunks +0 lines, -38 lines 0 comments Download
M webrtc/media/base/codec_unittest.cc View 1 12 chunks +16 lines, -76 lines 0 comments Download
M webrtc/media/base/mediaconstants.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/media/base/mediaconstants.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
magjed_webrtc
Created Revert of H264 codec: Check profile-level-id when matching
4 years, 2 months ago (2016-10-21 14:08:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2440123002/1
4 years, 2 months ago (2016-10-21 14:10:47 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_clang_dbg on ...
4 years, 2 months ago (2016-10-21 16:11:18 UTC) #6
magjed_webrtc
4 years, 1 month ago (2016-10-25 07:54:09 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:160001) manually as
06c8e1eaa7eb35c519c499f1d22d718213f71cc0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698