Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2440043004: Preventing TURN redirects to loopback addresses. (Closed)

Created:
4 years, 2 months ago by Taylor Brandstetter
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Preventing TURN redirects to loopback addresses. This can be used for a certain security exploit, and doesn't have any other practical applications we know of. BUG=chromium:649118 Committed: https://crrev.com/fb70b4503078503d7366f8cbe4928b2f437bd569 Cr-Commit-Position: refs/heads/master@{#14751}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -0 lines) Patch
M webrtc/p2p/base/turnport.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/p2p/base/turnport_unittest.cc View 3 chunks +69 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
honghaiz3
lgtm
4 years, 1 month ago (2016-10-24 17:44:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2440043004/1
4 years, 1 month ago (2016-10-24 19:15:34 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 20:16:03 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 20:16:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb70b4503078503d7366f8cbe4928b2f437bd569
Cr-Commit-Position: refs/heads/master@{#14751}

Powered by Google App Engine
This is Rietveld 408576698