Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 2439473002: Delete DataLog abstraction, which was almost unused. (Closed)

Created:
4 years, 2 months ago by nisse-webrtc
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), kwiberg-webrtc, fengyue_agora.io, zhengzhonghou_agora.io, henrika_webrtc, hlundin-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete DataLog abstraction, which was almost unused. Configuration with rtc_enable_data_logging = true was broken in cl https://codereview.webrtc.org/2054373002/ (which deleted the FileWrapper::WriteText method), and apparently noone noticed. BUG=None Committed: https://crrev.com/c4d2dc4e021cc676cc93be2c3278da115197e8c2 Cr-Commit-Position: refs/heads/master@{#14719}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1681 lines) Patch
M webrtc/build/common.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/build/webrtc.gni View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_unittest.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M webrtc/system_wrappers/BUILD.gn View 5 chunks +0 lines, -20 lines 0 comments Download
D webrtc/system_wrappers/include/data_log.h View 1 chunk +0 lines, -119 lines 0 comments Download
D webrtc/system_wrappers/include/data_log_c.h View 1 chunk +0 lines, -85 lines 0 comments Download
D webrtc/system_wrappers/include/data_log_impl.h View 1 chunk +0 lines, -157 lines 0 comments Download
D webrtc/system_wrappers/source/data_log.cc View 1 chunk +0 lines, -428 lines 0 comments Download
D webrtc/system_wrappers/source/data_log_c.cc View 1 chunk +0 lines, -143 lines 0 comments Download
D webrtc/system_wrappers/source/data_log_c_helpers_unittest.h View 1 chunk +0 lines, -58 lines 0 comments Download
D webrtc/system_wrappers/source/data_log_c_helpers_unittest.c View 1 chunk +0 lines, -123 lines 0 comments Download
D webrtc/system_wrappers/source/data_log_helpers_unittest.cc View 1 chunk +0 lines, -65 lines 0 comments Download
D webrtc/system_wrappers/source/data_log_no_op.cc View 1 chunk +0 lines, -88 lines 0 comments Download
D webrtc/system_wrappers/source/data_log_unittest.cc View 1 chunk +0 lines, -311 lines 0 comments Download
D webrtc/system_wrappers/source/data_log_unittest_disabled.cc View 1 chunk +0 lines, -55 lines 0 comments Download
M webrtc/system_wrappers/system_wrappers.gyp View 3 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
nisse-webrtc
Hi, this code is unused, except for (currently broken) logging functionality in webrtc/modules/audio_coding/neteq/audio_decoder_unittest.cc. If logging ...
4 years, 2 months ago (2016-10-19 11:21:49 UTC) #2
tommi
Rs lgtm but Henrik should have the last word
4 years, 2 months ago (2016-10-19 11:27:21 UTC) #3
hlundin-webrtc
lgtm
4 years, 2 months ago (2016-10-21 05:01:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2439473002/1
4 years, 2 months ago (2016-10-21 06:31:14 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 08:52:59 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 08:53:14 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c4d2dc4e021cc676cc93be2c3278da115197e8c2
Cr-Commit-Position: refs/heads/master@{#14719}

Powered by Google App Engine
This is Rietveld 408576698