Eliminate left shift of negative value by using multiplication instead

Eliminate left shift of negative value by using multiplication instead

NOPRESUBMIT=true
BUG=chromium:653267
Committed: https://crrev.com/bc8074474d3da08ce00d44362a5ae0d772bbf3a2
Cr-Commit-Position: refs/heads/master@{#14837}

[kwiberg-webrtc, 2016-10-24 11:31:23]

kwiberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org, ossu@webrtc.org

[kwiberg-webrtc, 2016-10-24 11:31:24]

This fixes the bug for me locally.

Henrik, by my reading of the code the lhs can legitimately be negative. Can you
confirm or deny?

[ossu, 2016-10-24 11:45:40]

On 2016/10/24 11:31:24, kwiberg-webrtc wrote:
> This fixes the bug for me locally.
> 
> Henrik, by my reading of the code the lhs can legitimately be negative. Can
you
> confirm or deny?

Ah, you beat me to it! I got stuck trying to get ubsan to build. LGTM though!

[kwiberg-chromium, 2016-10-24 12:01:19]

On 2016/10/24 11:45:40, ossu wrote:
> On 2016/10/24 11:31:24, kwiberg-webrtc wrote:
> > This fixes the bug for me locally.
> > 
> > Henrik, by my reading of the code the lhs can legitimately be negative. Can
> you
> > confirm or deny?
> 
> Ah, you beat me to it! I got stuck trying to get ubsan to build. LGTM though!

Ah, sorry, I got confused and behaved as though you'd reassigned the bug to me,
even though you specifically said this morning that you'd CCed me. Well, I guess
I'll go ahead and formally steal the bug from you then...

[ossu, 2016-10-24 12:04:16]

On 2016/10/24 12:01:19, kwiberg-chromium wrote:
> On 2016/10/24 11:45:40, ossu wrote:
> > On 2016/10/24 11:31:24, kwiberg-webrtc wrote:
> > > This fixes the bug for me locally.
> > > 
> > > Henrik, by my reading of the code the lhs can legitimately be negative.
Can
> > you
> > > confirm or deny?
> > 
> > Ah, you beat me to it! I got stuck trying to get ubsan to build. LGTM
though!
> 
> Ah, sorry, I got confused and behaved as though you'd reassigned the bug to
me,
> even though you specifically said this morning that you'd CCed me. Well, I
guess
> I'll go ahead and formally steal the bug from you then...

Do it! :)

[hlundin-webrtc, 2016-10-27 10:57:11]

lgtm

[kwiberg-webrtc, 2016-10-27 11:08:53]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-10-27 11:09:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-27 11:24:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 11:24:13]

Try jobs failed on following builders:
  win_x64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_dbg/builds/2503)

[kwiberg-webrtc, 2016-10-31 09:04:54]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-10-31 09:04:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-31 09:26:13]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-31 09:26:17]

Description was changed from

==========
Eliminate left shift of negative value by using multiplication instead

NOPRESUBMIT=true
BUG=chromium:653267
==========

to

==========
Eliminate left shift of negative value by using multiplication instead

NOPRESUBMIT=true
BUG=chromium:653267

Committed: https://crrev.com/bc8074474d3da08ce00d44362a5ae0d772bbf3a2
Cr-Commit-Position: refs/heads/master@{#14837}
==========

[commit-bot: I haz the power, 2016-10-31 09:26:17]

Patchset 1 (id:??) landed as
https://crrev.com/bc8074474d3da08ce00d44362a5ae0d772bbf3a2
Cr-Commit-Position: refs/heads/master@{#14837}