Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 2439263003: [Extensions Binding] Update ArgumentSpec to support dictionary enums (Closed)

Created:
4 years, 2 months ago by Devlin
Modified:
4 years, 2 months ago
Reviewers:
lazyboy, jbroman
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Binding] Update ArgumentSpec to support dictionary enums The enum definitions in our schemas can either be in the form of a list value with string entries (e.g. "enum": ["foo", "bar", "baz"]) or in the form of a dictionary with a name entry (e.g. "enum": [{"name": "foo"}]). Adjust ArgumentSpec to account for the latter, and add tests. BUG=653596 Committed: https://crrev.com/c92e571e82c2632768c1beec6087b704db84ccc3 Cr-Commit-Position: refs/heads/master@{#426999}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M extensions/renderer/argument_spec.cc View 1 chunk +7 lines, -1 line 0 comments Download
M extensions/renderer/argument_spec_unittest.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
Devlin
Forked, as requested.
4 years, 2 months ago (2016-10-22 00:53:04 UTC) #2
lazyboy
lgtm
4 years, 2 months ago (2016-10-22 01:03:21 UTC) #3
jbroman
lgtm
4 years, 2 months ago (2016-10-22 15:34:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2439263003/1
4 years, 2 months ago (2016-10-22 18:21:14 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-23 13:47:25 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-23 13:53:29 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c92e571e82c2632768c1beec6087b704db84ccc3
Cr-Commit-Position: refs/heads/master@{#426999}

Powered by Google App Engine
This is Rietveld 408576698