Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 2439073002: Allow using Java classes that don't require JNI in Chromium. (Closed)

Created:
4 years, 2 months ago by sakal
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Allow using Java classes that don't require JNI in Chromium. BUG=webrtc:6584 NOTRY=True Committed: https://crrev.com/ebf524007f47991c83073c5b54213d695be21bc1 Cr-Commit-Position: refs/heads/master@{#14730}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M webrtc/api/BUILD.gn View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
sakal
PTAL
4 years, 2 months ago (2016-10-21 13:42:22 UTC) #2
magjed_webrtc
lgtm. It's probably good to start reusing WebRTC Java code in Chromium. My only concern ...
4 years, 2 months ago (2016-10-21 14:14:15 UTC) #3
kjellander_chromium
lgtm please use NOTRY=True on this one.
4 years, 2 months ago (2016-10-21 19:01:23 UTC) #5
kjellander_webrtc
On 2016/10/21 19:01:23, kjellander_chromium wrote: > lgtm > > please use NOTRY=True on this one. ...
4 years, 2 months ago (2016-10-21 19:02:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2439073002/1
4 years, 1 month ago (2016-10-24 07:26:07 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 07:28:03 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 07:28:13 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ebf524007f47991c83073c5b54213d695be21bc1
Cr-Commit-Position: refs/heads/master@{#14730}

Powered by Google App Engine
This is Rietveld 408576698