Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2438973002: GN: move webrtc/video/ targets from webrtc/BUILD.gn into webrtc/video/BUILD.gn (Closed)

Created:
4 years, 2 months ago by kjellander_webrtc
Modified:
4 years, 1 month ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, mflodman, palmkvist
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: move webrtc/video/ targets from webrtc/BUILD.gn into webrtc/video/BUILD.gn Move the following targets into webrtc/video/BUILD.gn: * screenshare_loopback * video_quality_test * video_loopback Add new target 'run_tests' in webrtc/test/BUILD.gn, being used by two of the above and make then depend on that instead. BUG=webrtc:6440 NOTRY=True Committed: https://crrev.com/a3cac0514abf7e0eddcdab40abd858298cbc4f6c Cr-Commit-Position: refs/heads/master@{#14735}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add missing dependency on modules/video_capture:video_capture_module #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -79 lines) Patch
M webrtc/BUILD.gn View 4 chunks +1 line, -79 lines 0 comments Download
M webrtc/test/BUILD.gn View 1 2 chunks +13 lines, -0 lines 1 comment Download
M webrtc/video/BUILD.gn View 1 chunk +65 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
kjellander_webrtc
https://codereview.chromium.org/2438973002/diff/1/webrtc/BUILD.gn File webrtc/BUILD.gn (left): https://codereview.chromium.org/2438973002/diff/1/webrtc/BUILD.gn#oldcode742 webrtc/BUILD.gn:742: ":webrtc", Turns out this is not needed, which is ...
4 years, 2 months ago (2016-10-21 07:16:09 UTC) #3
kjellander_webrtc
https://codereview.chromium.org/2438973002/diff/1/webrtc/BUILD.gn File webrtc/BUILD.gn (left): https://codereview.chromium.org/2438973002/diff/1/webrtc/BUILD.gn#oldcode742 webrtc/BUILD.gn:742: ":webrtc", On 2016/10/21 07:16:09, kjellander_webrtc wrote: > Turns out ...
4 years, 1 month ago (2016-10-24 06:49:54 UTC) #4
stefan-webrtc
lgtm
4 years, 1 month ago (2016-10-24 08:39:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2438973002/20001
4 years, 1 month ago (2016-10-24 08:47:07 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-24 08:52:42 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 09:27:00 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a3cac0514abf7e0eddcdab40abd858298cbc4f6c
Cr-Commit-Position: refs/heads/master@{#14735}

Powered by Google App Engine
This is Rietveld 408576698