Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2438733002:
Added the missing ReadQueuedRenderData() call to the AEC bitexactness test (Closed)
|
Created:
4 years, 2 months ago by peah-webrtc Modified:
4 years, 2 months ago Reviewers:
ivoc CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1 Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdded the missing ReadQueuedRenderData() call to the AEC bitexactness test
BUG=webrtc:6572
Committed: https://crrev.com/da38293e51ba2a058ca75880d6f719d6e8b0a93b
Cr-Commit-Position: refs/heads/master@{#14723}
Patch Set 1 #Patch Set 2 : Updated test vectors #Patch Set 3 : Updated test vectors #Patch Set 4 : Updated test vectors #Patch Set 5 : Updated test vectors #Patch Set 6 : Updated test vectors #Patch Set 7 : Updated test vectors #Messages
Total messages: 22 (13 generated)
Description was changed from ========== Added the missing ReadQueuedRenderData() call to the AEC bitexactness test BUG= ========== to ========== Added the missing ReadQueuedRenderData() call to the AEC bitexactness test BUG=webrtc:6572 ==========
The CQ bit was checked by peah@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/19339)
peah@webrtc.org changed reviewers: + ivoc@webrtc.org
LGTM.
The CQ bit was checked by peah@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/15319)
The CQ bit was checked by peah@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_clang_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_compile_mips_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_compile_x64_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_compile_x86_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_compile_x86_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_gyp_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_arm on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_asan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_compile_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_gyp_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_libfuzzer_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_msan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_tsan2 on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_ubsan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_ubsan_vptr on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) presubmit on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by peah@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Added the missing ReadQueuedRenderData() call to the AEC bitexactness test BUG=webrtc:6572 ========== to ========== Added the missing ReadQueuedRenderData() call to the AEC bitexactness test BUG=webrtc:6572 ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== Added the missing ReadQueuedRenderData() call to the AEC bitexactness test BUG=webrtc:6572 ========== to ========== Added the missing ReadQueuedRenderData() call to the AEC bitexactness test BUG=webrtc:6572 Committed: https://crrev.com/da38293e51ba2a058ca75880d6f719d6e8b0a93b Cr-Commit-Position: refs/heads/master@{#14723} ==========
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/da38293e51ba2a058ca75880d6f719d6e8b0a93b Cr-Commit-Position: refs/heads/master@{#14723} |
