Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2438683004: [Devtools] Fixed scrollbar offset in new timeline experiment (Closed)

Created:
4 years, 2 months ago by allada
Modified:
4 years, 2 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Fixed scrollbar offset in new timeline experiment This patch fixes the timeline scrollbar offset for the canvas timeline experiment. R=dgozman BUG=653738 Committed: https://crrev.com/b3f1ac093d15f744e41fd0a89a44ac2b591ea294 Cr-Commit-Position: refs/heads/master@{#427000}

Patch Set 1 : Merge branch 'NETWORK_TIMELINE_10_ADD_COLOR_NAVIGATION' into NETWORK_TIMELINE_11_FIX_SCROLLBAR #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js View 4 chunks +14 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/networkTimelineColumn.css View 2 chunks +3 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
allada
PTL
4 years, 2 months ago (2016-10-21 00:39:05 UTC) #4
dgozman
lgtm
4 years, 2 months ago (2016-10-21 20:34:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438683004/100001
4 years, 2 months ago (2016-10-22 15:26:02 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:100001)
4 years, 2 months ago (2016-10-23 13:49:00 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-23 13:53:31 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b3f1ac093d15f744e41fd0a89a44ac2b591ea294
Cr-Commit-Position: refs/heads/master@{#427000}

Powered by Google App Engine
This is Rietveld 408576698