Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Issue 2438023005: Open th32Process when enumerating processes. (Closed)

Created:
4 years, 2 months ago by anpol
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Open th32Process when enumerating processes. PROCESSENTRY32 is the structure filled by Process32First/Process32Next, and |th32Process| is the handle of the process to be opened for further investigation. The previous use of |th32ParentProcessID| have caused collecting a redundant information about the parent process itself. An example on how to enumerate child processes: https://msdn.microsoft.com/library/windows/desktop/ms686701(v=vs.85).aspx BUG= Committed: https://crrev.com/032dbbee170e56ea8ddaf687d8f28495da5ca0a2 Cr-Commit-Position: refs/heads/master@{#429129}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/debug/gdi_debug_util_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
anpol
4 years, 2 months ago (2016-10-22 14:51:10 UTC) #3
anpol
PTAL
4 years, 1 month ago (2016-10-25 08:52:54 UTC) #5
anpol
4 years, 1 month ago (2016-10-25 08:53:14 UTC) #6
Lei Zhang
This looks reasonable to me, I'm not sure how this ever worked correctly then. Maybe ...
4 years, 1 month ago (2016-10-25 18:26:42 UTC) #8
anpol
PTAL
4 years, 1 month ago (2016-11-01 04:50:26 UTC) #9
Lei Zhang
lgtm
4 years, 1 month ago (2016-11-01 20:53:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438023005/1
4 years, 1 month ago (2016-11-01 20:53:51 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-01 21:54:15 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/032dbbee170e56ea8ddaf687d8f28495da5ca0a2 Cr-Commit-Position: refs/heads/master@{#429129}
4 years, 1 month ago (2016-11-01 21:56:36 UTC) #16
ananta
4 years, 1 month ago (2016-11-01 22:31:56 UTC) #17
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698