Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 2437863003: Delete unused class AudioSourceWithMixStatus. (Closed)

Created:
4 years, 2 months ago by nisse-webrtc
Modified:
4 years, 1 month ago
Reviewers:
aleloi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unused class AudioSourceWithMixStatus. BUG=webrtc:6346 Committed: https://crrev.com/151572ba05d0ef1981d23b2206450cb006057fb4 Cr-Commit-Position: refs/heads/master@{#14728}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -92 lines) Patch
M webrtc/modules/audio_mixer/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_mixer/audio_mixer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/modules/audio_mixer/audio_source_with_mix_status.h View 1 chunk +0 lines, -45 lines 0 comments Download
D webrtc/modules/audio_mixer/audio_source_with_mix_status.cc View 1 chunk +0 lines, -43 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
nisse-webrtc
PTAL. You no longer used this, right?
4 years, 2 months ago (2016-10-20 13:18:30 UTC) #2
aleloi
Oh, I didn't realize that the file was still left! Now I see that I ...
4 years, 2 months ago (2016-10-20 13:24:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2437863003/1
4 years, 2 months ago (2016-10-20 13:29:08 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_clang_dbg on ...
4 years, 2 months ago (2016-10-20 15:29:49 UTC) #7
aleloi
I think we can land it anyway with NOTRY=True: it's not a code change and ...
4 years, 2 months ago (2016-10-20 15:42:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2437863003/1
4 years, 2 months ago (2016-10-21 06:59:26 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 2 months ago (2016-10-21 08:59:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2437863003/1
4 years, 2 months ago (2016-10-21 11:15:37 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 2 months ago (2016-10-21 13:16:17 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2437863003/1
4 years, 1 month ago (2016-10-24 06:35:09 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 07:11:54 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 07:12:05 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/151572ba05d0ef1981d23b2206450cb006057fb4
Cr-Commit-Position: refs/heads/master@{#14728}

Powered by Google App Engine
This is Rietveld 408576698