Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2437703002: Delete unused file mediacommon.h. (Closed)

Created:
4 years, 2 months ago by nisse-webrtc
Modified:
4 years, 2 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, pthatcher1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unused file mediacommon.h. BUG=None Committed: https://crrev.com/a34e796a1b59a1068c77a3e36d2a24fd37c08afc Cr-Commit-Position: refs/heads/master@{#14689}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -30 lines) Patch
M webrtc/media/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/media/base/mediacommon.h View 1 chunk +0 lines, -27 lines 0 comments Download
M webrtc/media/base/mediaengine.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/media/media.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
nisse-webrtc
This appears unused.
4 years, 2 months ago (2016-10-19 09:29:41 UTC) #2
magjed_webrtc
lgtm
4 years, 2 months ago (2016-10-19 10:36:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2437703002/1
4 years, 2 months ago (2016-10-19 10:39:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_compile_x86_rel on ...
4 years, 2 months ago (2016-10-19 12:40:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2437703002/1
4 years, 2 months ago (2016-10-19 13:12:34 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 2 months ago (2016-10-19 15:12:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2437703002/1
4 years, 2 months ago (2016-10-20 07:30:37 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 07:44:58 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a34e796a1b59a1068c77a3e36d2a24fd37c08afc Cr-Commit-Position: refs/heads/master@{#14689}
4 years, 2 months ago (2016-10-20 07:45:06 UTC) #16
nisse-webrtc
4 years, 2 months ago (2016-10-20 09:52:39 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2441493003/ by nisse@webrtc.org.

The reason for reverting is: Turned out this broke a downstream app. Reverting
while investigating..

Powered by Google App Engine
This is Rietveld 408576698