Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: webrtc/video/video_send_stream_tests.cc

Issue 2437503004: Set actual transport overhead in rtp_rtcp (Closed)
Patch Set: Fix bugs discoverd with unittest. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video/video_send_stream_tests.cc
diff --git a/webrtc/video/video_send_stream_tests.cc b/webrtc/video/video_send_stream_tests.cc
index 5c836e0f99b61faf33bb75a89890b31a381dc8d6..9b2b4551a2334e171050b093156bf6e29a60f193 100644
--- a/webrtc/video/video_send_stream_tests.cc
+++ b/webrtc/video/video_send_stream_tests.cc
@@ -1325,6 +1325,47 @@ TEST_F(VideoSendStreamTest, ChangingNetworkRoute) {
RunBaseTest(&test);
}
+TEST_F(VideoSendStreamTest, ChangingTransportOverhead) {
+ class ChangingTransportOverheadTest : public test::EndToEndTest {
+ public:
+ ChangingTransportOverheadTest()
+ : EndToEndTest(test::CallTest::kDefaultTimeoutMs),
+ call_(nullptr),
+ packets_sent_(0) {}
+
+ void OnCallsCreated(Call* sender_call, Call* receiver_call) override {
+ call_ = sender_call;
+ }
+
+ Action OnSendRtp(const uint8_t* packet, size_t length) override {
+ EXPECT_LE(length, IP_PACKET_SIZE - transport_overhead_);
+ if (++packets_sent_ < 100)
+ return SEND_PACKET;
+ observation_complete_.Set();
+ return SEND_PACKET;
+ }
+
+ void PerformTest() override {
+ transport_overhead_ = 500;
+ call_->OnTransportOverheadChanged(webrtc::MediaType::VIDEO,
+ transport_overhead_);
+ EXPECT_TRUE(Wait());
+ packets_sent_ = 0;
+ transport_overhead_ = 1000;
+ call_->OnTransportOverheadChanged(webrtc::MediaType::VIDEO,
+ transport_overhead_);
+ EXPECT_TRUE(Wait());
+ }
+
+ private:
+ Call* call_;
+ int packets_sent_;
+ size_t transport_overhead_;
+ } test;
+
+ RunBaseTest(&test);
+}
+
class MaxPaddingSetTest : public test::SendTest {
public:
static const uint32_t kMinTransmitBitrateBps = 400000;

Powered by Google App Engine
This is Rietveld 408576698