Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: webrtc/video/video_send_stream.cc

Issue 2437503004: Set actual transport overhead in rtp_rtcp (Closed)
Patch Set: Response to comments of honghaiz3 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video/video_send_stream.cc
diff --git a/webrtc/video/video_send_stream.cc b/webrtc/video/video_send_stream.cc
index cb6689e1179bdfb24e7543fd2797a0b4e3d5be41..291075756aa3334c567da7a5b64008bbcd59622b 100644
--- a/webrtc/video/video_send_stream.cc
+++ b/webrtc/video/video_send_stream.cc
@@ -274,6 +274,8 @@ class VideoSendStreamImpl : public webrtc::BitrateAllocatorObserver,
void EnableEncodedFrameRecording(const std::vector<rtc::PlatformFile>& files,
size_t byte_limit);
+ void SetTransportOverhead(int transport_overhead_per_packet_byte);
+
private:
class CheckEncoderActivityTask;
class EncoderReconfiguredTask;
@@ -617,6 +619,15 @@ VideoSendStream::RtpStateMap VideoSendStream::StopPermanentlyAndGetRtpStates() {
return state_map;
}
+void VideoSendStream::SetTransportOverhead(
+ int transport_overhead_per_packet_byte) {
+ RTC_DCHECK_RUN_ON(&thread_checker_);
+ VideoSendStreamImpl* send_stream = send_stream_.get();
+ worker_queue_->PostTask([send_stream, transport_overhead_per_packet_byte] {
+ send_stream->SetTransportOverhead(transport_overhead_per_packet_byte);
+ });
+}
+
bool VideoSendStream::DeliverRtcp(const uint8_t* packet, size_t length) {
// Called on a network thread.
return send_stream_->DeliverRtcp(packet, length);
@@ -1112,5 +1123,12 @@ int VideoSendStreamImpl::ProtectionRequest(
return 0;
}
+void VideoSendStreamImpl::SetTransportOverhead(
+ int transport_overhead_per_packet_byte) {
+ for (RtpRtcp* rtp_rtcp : rtp_rtcp_modules_) {
stefan-webrtc 2016/11/02 13:21:43 You can remove {}
michaelt 2016/11/02 13:35:34 Acknowledged.
+ rtp_rtcp->SetTransportOverhead(transport_overhead_per_packet_byte);
+ }
+}
+
} // namespace internal
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698