Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Side by Side Diff: webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

Issue 2437503004: Set actual transport overhead in rtp_rtcp (Closed)
Patch Set: Add unittest for changing transport overhead. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 // |size| - Max transfer unit in bytes, default is 1500. 108 // |size| - Max transfer unit in bytes, default is 1500.
109 // Returns -1 on failure else 0. 109 // Returns -1 on failure else 0.
110 virtual int32_t SetMaxTransferUnit(uint16_t size) = 0; 110 virtual int32_t SetMaxTransferUnit(uint16_t size) = 0;
111 111
112 // Sets transtport overhead. Default is IPv4 and UDP with no encryption. 112 // Sets transtport overhead. Default is IPv4 and UDP with no encryption.
113 // |tcp| - true for TCP false UDP. 113 // |tcp| - true for TCP false UDP.
114 // |ipv6| - true for IP version 6 false for version 4. 114 // |ipv6| - true for IP version 6 false for version 4.
115 // |authentication_overhead| - number of bytes to leave for an authentication 115 // |authentication_overhead| - number of bytes to leave for an authentication
116 // header. 116 // header.
117 // Returns -1 on failure else 0 117 // Returns -1 on failure else 0
118 // TODO(michaelt): deprecate the function.
118 virtual int32_t SetTransportOverhead(bool tcp, 119 virtual int32_t SetTransportOverhead(bool tcp,
119 bool ipv6, 120 bool ipv6,
120 uint8_t authentication_overhead = 0) = 0; 121 uint8_t authentication_overhead = 0) = 0;
121 122
123 // Sets transtport overhead per packet.
124 virtual void SetTransportOverhead(int transport_overhead_per_packet) = 0;
125
122 // Returns max payload length, which is a combination of the configuration 126 // Returns max payload length, which is a combination of the configuration
123 // MaxTransferUnit and TransportOverhead. 127 // MaxTransferUnit and TransportOverhead.
124 // Does not account for RTP headers and FEC/ULP/RED overhead (when FEC is 128 // Does not account for RTP headers and FEC/ULP/RED overhead (when FEC is
125 // enabled). 129 // enabled).
126 virtual uint16_t MaxPayloadLength() const = 0; 130 virtual uint16_t MaxPayloadLength() const = 0;
127 131
128 // Returns max data payload length, which is a combination of the 132 // Returns max data payload length, which is a combination of the
129 // configuration MaxTransferUnit, headers and TransportOverhead. 133 // configuration MaxTransferUnit, headers and TransportOverhead.
130 // Takes into account RTP headers and FEC/ULP/RED overhead (when FEC is 134 // Takes into account RTP headers and FEC/ULP/RED overhead (when FEC is
131 // enabled). 135 // enabled).
(...skipping 339 matching lines...) Expand 10 before | Expand all | Expand 10 after
471 virtual int32_t SetKeyFrameRequestMethod(KeyFrameRequestMethod method) = 0; 475 virtual int32_t SetKeyFrameRequestMethod(KeyFrameRequestMethod method) = 0;
472 476
473 // Sends a request for a keyframe. 477 // Sends a request for a keyframe.
474 // Returns -1 on failure else 0. 478 // Returns -1 on failure else 0.
475 virtual int32_t RequestKeyFrame() = 0; 479 virtual int32_t RequestKeyFrame() = 0;
476 }; 480 };
477 481
478 } // namespace webrtc 482 } // namespace webrtc
479 483
480 #endif // WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_ 484 #endif // WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698