Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Side by Side Diff: webrtc/media/engine/webrtcvideoengine2.cc

Issue 2437503004: Set actual transport overhead in rtp_rtcp (Closed)
Patch Set: Response to comments of honghaiz3 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 1506 matching lines...) Expand 10 before | Expand all | Expand 10 after
1517 webrtc::MediaType::VIDEO, 1517 webrtc::MediaType::VIDEO,
1518 ready ? webrtc::kNetworkUp : webrtc::kNetworkDown); 1518 ready ? webrtc::kNetworkUp : webrtc::kNetworkDown);
1519 } 1519 }
1520 1520
1521 void WebRtcVideoChannel2::OnNetworkRouteChanged( 1521 void WebRtcVideoChannel2::OnNetworkRouteChanged(
1522 const std::string& transport_name, 1522 const std::string& transport_name,
1523 const rtc::NetworkRoute& network_route) { 1523 const rtc::NetworkRoute& network_route) {
1524 call_->OnNetworkRouteChanged(transport_name, network_route); 1524 call_->OnNetworkRouteChanged(transport_name, network_route);
1525 } 1525 }
1526 1526
1527 void WebRtcVideoChannel2::OnTransportOverheadChange(
1528 int transport_overhead_per_packet) {
1529 call_->SignalTransportOverheadChange(webrtc::MediaType::VIDEO,
stefan-webrtc 2016/11/02 13:21:43 Why SignalTransportOverheadChange instead of OnTra
michaelt 2016/11/02 13:35:34 SignalNetworkState was the prototype for this func
stefan-webrtc 2016/11/02 13:41:09 I'd prefer On to align with the other functions in
michaelt 2016/11/02 15:13:38 Done.
1530 transport_overhead_per_packet);
1531 }
1532
1527 void WebRtcVideoChannel2::SetInterface(NetworkInterface* iface) { 1533 void WebRtcVideoChannel2::SetInterface(NetworkInterface* iface) {
1528 MediaChannel::SetInterface(iface); 1534 MediaChannel::SetInterface(iface);
1529 // Set the RTP recv/send buffer to a bigger size 1535 // Set the RTP recv/send buffer to a bigger size
1530 MediaChannel::SetOption(NetworkInterface::ST_RTP, 1536 MediaChannel::SetOption(NetworkInterface::ST_RTP,
1531 rtc::Socket::OPT_RCVBUF, 1537 rtc::Socket::OPT_RCVBUF,
1532 kVideoRtpBufferSize); 1538 kVideoRtpBufferSize);
1533 1539
1534 // Speculative change to increase the outbound socket buffer size. 1540 // Speculative change to increase the outbound socket buffer size.
1535 // In b/15152257, we are seeing a significant number of packets discarded 1541 // In b/15152257, we are seeing a significant number of packets discarded
1536 // due to lack of socket buffer space, although it's not yet clear what the 1542 // due to lack of socket buffer space, although it's not yet clear what the
(...skipping 1155 matching lines...) Expand 10 before | Expand all | Expand 10 after
2692 rtx_mapping[video_codecs[i].codec.id] != 2698 rtx_mapping[video_codecs[i].codec.id] !=
2693 ulpfec_config.red_payload_type) { 2699 ulpfec_config.red_payload_type) {
2694 video_codecs[i].rtx_payload_type = rtx_mapping[video_codecs[i].codec.id]; 2700 video_codecs[i].rtx_payload_type = rtx_mapping[video_codecs[i].codec.id];
2695 } 2701 }
2696 } 2702 }
2697 2703
2698 return video_codecs; 2704 return video_codecs;
2699 } 2705 }
2700 2706
2701 } // namespace cricket 2707 } // namespace cricket
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698