Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2437033002: Added the missing ReadQueuedRenderData() call to the AECM bitexactness test (Closed)

Created:
4 years, 2 months ago by peah-webrtc
Modified:
4 years, 2 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Added the missing ReadQueuedRenderData() call to the AECM bitexactness test BUG=webrtc:6573 Committed: https://crrev.com/897497361e18c604ad46b949c7b478db9709734f Cr-Commit-Position: refs/heads/master@{#14725}

Patch Set 1 #

Patch Set 2 : Updated test vectors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M webrtc/modules/audio_processing/echo_control_mobile_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 21 (12 generated)
peah-webrtc
4 years, 2 months ago (2016-10-21 10:28:40 UTC) #6
ivoc
LGTM.
4 years, 2 months ago (2016-10-21 11:18:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2437033002/20001
4 years, 2 months ago (2016-10-21 11:22:07 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 2 months ago (2016-10-21 13:22:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2437033002/20001
4 years, 2 months ago (2016-10-21 22:51:43 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 2 months ago (2016-10-22 00:52:20 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2437033002/20001
4 years, 2 months ago (2016-10-22 07:53:52 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-22 11:00:32 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-22 11:00:49 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/897497361e18c604ad46b949c7b478db9709734f
Cr-Commit-Position: refs/heads/master@{#14725}

Powered by Google App Engine
This is Rietveld 408576698