Android YuvConverter: Use OpenGL Framebuffer instead of EGL pixel buffer

Android YuvConverter: Use OpenGL Framebuffer instead of EGL pixel buffer

This CL changes YuvConverter to use an OpenGL Framebuffer as rendering
target instead of an EGL pixel buffer surface. The purpose is to reduce
the number of EGL contexts and to be able to use YuvConverter from
EglRenderer without having to detach the EGL surface.

BUG=webrtc:6470
Committed: https://crrev.com/1cb48232acfe5189311c8e25d3e0ffb07c754841
Cr-Commit-Position: refs/heads/master@{#14699}

[magjed_webrtc, 2016-10-19 11:11:32]

Description was changed from

==========
Android YuvConverter: Use OpenGL Framebuffer instead of EGL pixel buffer

This CL changes YuvConverter to use an OpenGL Framebuffer as rendering
target instead of an EGL pixel buffer surface. The purpose is to reduce
the number of EGL contexts and to be able to use YuvConverter from
EglRenderer without having to detach the EGL surface.

BUG=webrtc:6470
==========

to

==========
Android YuvConverter: Use OpenGL Framebuffer instead of EGL pixel buffer

This CL changes YuvConverter to use an OpenGL Framebuffer as rendering
target instead of an EGL pixel buffer surface. The purpose is to reduce
the number of EGL contexts and to be able to use YuvConverter from
EglRenderer without having to detach the EGL surface.

BUG=webrtc:6470
==========

[magjed_webrtc, 2016-10-19 11:11:33]

magjed@webrtc.org changed reviewers:
+ sakal@webrtc.org

[magjed_webrtc, 2016-10-19 11:11:43]

Sami - please take a look.

[sakal, 2016-10-19 11:37:56]

lgtm

https://codereview.webrtc.org/2436653003/diff/1/webrtc/api/android/java/src/o...
File webrtc/api/android/java/src/org/webrtc/YuvConverter.java (right):

https://codereview.webrtc.org/2436653003/diff/1/webrtc/api/android/java/src/o...
webrtc/api/android/java/src/org/webrtc/YuvConverter.java:83: private final int
frameBufferId;
nit: I would prefer to separate final members from the rest.

[magjed_webrtc, 2016-10-19 12:30:11]

https://codereview.webrtc.org/2436653003/diff/1/webrtc/api/android/java/src/o...
File webrtc/api/android/java/src/org/webrtc/YuvConverter.java (right):

https://codereview.webrtc.org/2436653003/diff/1/webrtc/api/android/java/src/o...
webrtc/api/android/java/src/org/webrtc/YuvConverter.java:83: private final int
frameBufferId;
On 2016/10/19 11:37:56, sakal wrote:
> nit: I would prefer to separate final members from the rest.

Done.

[magjed_webrtc, 2016-10-19 14:05:35]

PTAL - I had to do a non-trivial rebase.

[sakal, 2016-10-19 14:28:00]

still lgtm

[magjed_webrtc, 2016-10-19 14:45:38]

The CQ bit was checked by magjed@webrtc.org

[commit-bot: I haz the power, 2016-10-19 14:45:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-19 16:46:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 16:46:22]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_clang_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_compile_mips_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build
URL)
  android_compile_x64_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build
URL)
  android_compile_x86_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build
URL)
  android_compile_x86_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build
URL)
  android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_gyp_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_arm on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_asan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_compile_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_gyp_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_libfuzzer_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_msan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_tsan2 on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_ubsan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_ubsan_vptr on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  presubmit on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[magjed_webrtc, 2016-10-20 08:52:37]

The CQ bit was checked by magjed@webrtc.org

[commit-bot: I haz the power, 2016-10-20 08:52:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-20 10:19:20]

Description was changed from

==========
Android YuvConverter: Use OpenGL Framebuffer instead of EGL pixel buffer

This CL changes YuvConverter to use an OpenGL Framebuffer as rendering
target instead of an EGL pixel buffer surface. The purpose is to reduce
the number of EGL contexts and to be able to use YuvConverter from
EglRenderer without having to detach the EGL surface.

BUG=webrtc:6470
==========

to

==========
Android YuvConverter: Use OpenGL Framebuffer instead of EGL pixel buffer

This CL changes YuvConverter to use an OpenGL Framebuffer as rendering
target instead of an EGL pixel buffer surface. The purpose is to reduce
the number of EGL contexts and to be able to use YuvConverter from
EglRenderer without having to detach the EGL surface.

BUG=webrtc:6470
==========

[commit-bot: I haz the power, 2016-10-20 10:19:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-20 10:19:23]

Description was changed from

==========
Android YuvConverter: Use OpenGL Framebuffer instead of EGL pixel buffer

This CL changes YuvConverter to use an OpenGL Framebuffer as rendering
target instead of an EGL pixel buffer surface. The purpose is to reduce
the number of EGL contexts and to be able to use YuvConverter from
EglRenderer without having to detach the EGL surface.

BUG=webrtc:6470
==========

to

==========
Android YuvConverter: Use OpenGL Framebuffer instead of EGL pixel buffer

This CL changes YuvConverter to use an OpenGL Framebuffer as rendering
target instead of an EGL pixel buffer surface. The purpose is to reduce
the number of EGL contexts and to be able to use YuvConverter from
EglRenderer without having to detach the EGL surface.

BUG=webrtc:6470

Committed: https://crrev.com/1cb48232acfe5189311c8e25d3e0ffb07c754841
Cr-Commit-Position: refs/heads/master@{#14699}
==========

[commit-bot: I haz the power, 2016-10-20 10:19:25]

Patchset 3 (id:??) landed as
https://crrev.com/1cb48232acfe5189311c8e25d3e0ffb07c754841
Cr-Commit-Position: refs/heads/master@{#14699}