Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2435963002: Reland of Delete webrtc::VideoFrame::CopyFrame. (Closed)

Created:
4 years, 2 months ago by nisse-webrtc
Modified:
4 years, 1 month ago
Reviewers:
magjed_webrtc, tommi, ivoc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, perkj_webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Delete webrtc::VideoFrame::CopyFrame. (patchset #1 id:1 of https://codereview.webrtc.org/2397943003/ ) Reason for revert: Dependencies updated. Original issue's description: > Revert of Delete webrtc::VideoFrame::CopyFrame. (patchset #2 id:20001 of https://codereview.webrtc.org/2371363003/ ) > > Reason for revert: > This CL breaks internal dependencies. > > Original issue's description: > > Delete webrtc::VideoFrame::CopyFrame. > > > > BUG=webrtc:5682 > > > > Committed: https://crrev.com/0e7c7ce35d9449c5bb13328d1bfb04ad32e48ccc > > Cr-Commit-Position: refs/heads/master@{#14550} > > TBR=magjed@webrtc.org,tommi@webrtc.org,nisse@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5682 > > Committed: https://crrev.com/21a18ee267146c86e188d95edf6432f71dd53aeb > Cr-Commit-Position: refs/heads/master@{#14553} TBR=magjed@webrtc.org,tommi@webrtc.org,ivoc@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:5682 Committed: https://crrev.com/61c053e329ebe30da5866f39084dbc11f40a1b3b Cr-Commit-Position: refs/heads/master@{#14731}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -65 lines) Patch
M webrtc/common_video/i420_video_frame_unittest.cc View 2 chunks +0 lines, -44 lines 0 comments Download
M webrtc/common_video/video_frame.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_processing/test/video_processing_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/video_frame.h View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
nisse-webrtc
Created Reland of Delete webrtc::VideoFrame::CopyFrame.
4 years, 2 months ago (2016-10-20 07:37:47 UTC) #1
magjed_webrtc
lgtm
4 years, 2 months ago (2016-10-20 14:07:10 UTC) #2
ivoc
lgtm
4 years, 2 months ago (2016-10-20 14:09:23 UTC) #3
tommi
lgtm
4 years, 2 months ago (2016-10-20 16:04:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2435963002/1
4 years, 2 months ago (2016-10-21 06:34:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_clang_dbg on ...
4 years, 2 months ago (2016-10-21 08:35:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2435963002/1
4 years, 2 months ago (2016-10-21 10:38:56 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 2 months ago (2016-10-21 12:39:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2435963002/1
4 years, 2 months ago (2016-10-24 06:36:10 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 07:44:16 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 07:44:25 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/61c053e329ebe30da5866f39084dbc11f40a1b3b
Cr-Commit-Position: refs/heads/master@{#14731}

Powered by Google App Engine
This is Rietveld 408576698