Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issue 2435293002: Add tests and fix thread annotations (Closed)

Created:
4 years, 2 months ago by danilchap
Modified:
4 years, 1 month ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add tests and fix thread annotations BUG=None NOTRY=true Committed: https://crrev.com/01404084aa9c4656bc3607c70dbf5ce204a706f9 Cr-Commit-Position: refs/heads/master@{#14742}

Patch Set 1 #

Patch Set 2 : include more generic gtest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -4 lines) Patch
M webrtc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/thread_annotations.h View 3 chunks +5 lines, -4 lines 0 comments Download
A webrtc/base/thread_annotations_unittest.cc View 1 1 chunk +151 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
danilchap
4 years, 1 month ago (2016-10-24 08:45:08 UTC) #3
tommi
lgtm!
4 years, 1 month ago (2016-10-24 09:44:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2435293002/20001
4 years, 1 month ago (2016-10-24 13:05:30 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-24 13:07:31 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 13:07:40 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/01404084aa9c4656bc3607c70dbf5ce204a706f9
Cr-Commit-Position: refs/heads/master@{#14742}

Powered by Google App Engine
This is Rietveld 408576698