Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2434803002:
QualityScaler reset bugfix (Closed)
|
Created:
4 years, 2 months ago by kthelgason Modified:
4 years, 2 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionQualityScaler reset bugfix
BUG=webrtc:6563
TBR=sprang@webrtc.org
Committed: https://crrev.com/55928fef1e1579debf442b17b39007e0525e03a4
Cr-Commit-Position: refs/heads/master@{#14688}
Patch Set 1 #
Messages
Total messages: 19 (13 generated)
kthelgason@webrtc.org changed reviewers: + magjed@webrtc.org
PTAL. Verified that it works now.
The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
lgtm
kthelgason@webrtc.org changed reviewers: + sprang@webrtc.org
Erik, can you take a look as well?
Description was changed from ========== QualityScaler reset bugfix BUG=webrtc:6304 ========== to ========== QualityScaler reset bugfix BUG=webrtc:6304,webrtc:6563 ==========
Description was changed from ========== QualityScaler reset bugfix BUG=webrtc:6304,webrtc:6563 ========== to ========== QualityScaler reset bugfix BUG=webrtc:6304 BUG=webrtc:6563 ==========
Description was changed from ========== QualityScaler reset bugfix BUG=webrtc:6304 BUG=webrtc:6563 ========== to ========== QualityScaler reset bugfix BUG=webrtc:6563 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_x64_clang_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_clang_dbg/build...)
Description was changed from ========== QualityScaler reset bugfix BUG=webrtc:6563 ========== to ========== QualityScaler reset bugfix BUG=webrtc:6563 TBR=sprang@webrtc.org ==========
The CQ bit was checked by kthelgason@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== QualityScaler reset bugfix BUG=webrtc:6563 TBR=sprang@webrtc.org ========== to ========== QualityScaler reset bugfix BUG=webrtc:6563 TBR=sprang@webrtc.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== QualityScaler reset bugfix BUG=webrtc:6563 TBR=sprang@webrtc.org ========== to ========== QualityScaler reset bugfix BUG=webrtc:6563 TBR=sprang@webrtc.org Committed: https://crrev.com/55928fef1e1579debf442b17b39007e0525e03a4 Cr-Commit-Position: refs/heads/master@{#14688} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/55928fef1e1579debf442b17b39007e0525e03a4 Cr-Commit-Position: refs/heads/master@{#14688} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
