Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2434563003: Remove all traces of Dr Memory. (Closed)

Created:
4 years, 2 months ago by kjellander_webrtc
Modified:
4 years, 2 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove all traces of Dr Memory. The Dr Memory toolchain is no longer supported by Chromium and their bots have been removed. WebRTC will now rely on the LLVM santizers for catching such errors. BUG=webrtc:6553 NOTRY=True R=ehmaldonado@webrtc.org Committed: https://crrev.com/057b8d91a63b7827da48b82ba0433845902eaa8d Cr-Commit-Position: refs/heads/master@{#14703}

Patch Set 1 #

Patch Set 2 : Removed from CQ config as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -934 lines) Patch
M .gitignore View 1 chunk +0 lines, -1 line 0 comments Download
M infra/config/cq.cfg View 1 1 chunk +0 lines, -1 line 0 comments Download
M setup_links.py View 1 chunk +0 lines, -1 line 0 comments Download
D tools/valgrind-webrtc/drmemory/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D tools/valgrind-webrtc/drmemory/PRESUBMIT.py View 1 chunk +0 lines, -47 lines 0 comments Download
D tools/valgrind-webrtc/drmemory/suppressions.txt View 1 chunk +0 lines, -659 lines 0 comments Download
D tools/valgrind-webrtc/gtest_exclude/common_video_unittests.gtest-drmemory_win32.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D tools/valgrind-webrtc/gtest_exclude/modules_tests.gtest-drmemory.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D tools/valgrind-webrtc/gtest_exclude/modules_unittests.gtest-drmemory_win32.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D tools/valgrind-webrtc/gtest_exclude/peerconnection_unittests.gtest-drmemory_win32.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D tools/valgrind-webrtc/gtest_exclude/rtc_media_unittests.gtest-drmemory_win32.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D tools/valgrind-webrtc/gtest_exclude/rtc_pc_unittests.gtest-drmemory_win32.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D tools/valgrind-webrtc/gtest_exclude/rtc_unittests.gtest-drmemory.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D tools/valgrind-webrtc/gtest_exclude/system_wrappers_unittests.gtest-drmemory_win32.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D tools/valgrind-webrtc/gtest_exclude/video_engine_tests.gtest-drmemory_win32.txt View 1 chunk +0 lines, -27 lines 0 comments Download
D tools/valgrind-webrtc/gtest_exclude/webrtc_nonparallel_tests.gtest-drmemory_win32.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D tools/valgrind-webrtc/gtest_exclude/xmllite_xmpp_unittests.gtest-drmemory_win32.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D tools/valgrind-webrtc/webrtc_tests.bat View 1 chunk +0 lines, -63 lines 0 comments Download
M tools/valgrind-webrtc/webrtc_tests.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/valgrind-webrtc/webrtc_tests.sh View 3 chunks +3 lines, -27 lines 0 comments Download
M webrtc/build/mb_config.pyl View 4 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
kjellander_webrtc
4 years, 2 months ago (2016-10-19 10:35:14 UTC) #3
ehmaldonado_webrtc
On 2016/10/19 10:35:14, kjellander_webrtc wrote: LGTM
4 years, 2 months ago (2016-10-20 10:47:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2434563003/20001
4 years, 2 months ago (2016-10-20 11:12:52 UTC) #6
kjellander_webrtc
4 years, 2 months ago (2016-10-20 11:17:31 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
057b8d91a63b7827da48b82ba0433845902eaa8d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698