Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 2434533003: Remove check for numberOfCameras from AppRTC Mobile PeerConnectionClient. (Closed)

Created:
4 years, 2 months ago by sakal
Modified:
4 years, 2 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove check for numberOfCameras from AppRTC Mobile PeerConnectionClient. Since the class no longer creates its own videoCapturer and it may not even be a camera, the check doesn't make sense anymore. This also removes some of the build warnings. BUG=webrtc:6558 Committed: https://crrev.com/c1f8ecb66104c6427395dfd9fd3107df7c574d9c Cr-Commit-Position: refs/heads/master@{#14696}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java View 5 chunks +3 lines, -13 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
sakal
PTAL
4 years, 2 months ago (2016-10-19 13:45:59 UTC) #3
magjed_webrtc
lgtm
4 years, 2 months ago (2016-10-19 13:56:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2434533003/1
4 years, 2 months ago (2016-10-19 14:04:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_clang_dbg on ...
4 years, 2 months ago (2016-10-19 16:05:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2434533003/1
4 years, 2 months ago (2016-10-20 08:36:48 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 09:34:49 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-20 09:34:59 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1f8ecb66104c6427395dfd9fd3107df7c574d9c
Cr-Commit-Position: refs/heads/master@{#14696}

Powered by Google App Engine
This is Rietveld 408576698