Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 2434263002: 📰 Refresh the visiblity of AllDismissed when items change (Closed)

Created:
4 years, 2 months ago by dgn
Modified:
4 years, 1 month ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Client] Refresh the visiblity of AllDismissed when items change Adds a mocking method for Feature flags in SnippetsConfig BUG=657319 Committed: https://crrev.com/372bfbd50af98d1b80ff215fb8040b530db54196 Cr-Commit-Position: refs/heads/master@{#427090}

Patch Set 1 #

Patch Set 2 : add/fix tests #

Patch Set 3 : Update test comments #

Total comments: 7

Patch Set 4 : comments #

Patch Set 5 : comments #

Patch Set 6 : #

Patch Set 7 : check the index in getStartingOffsetForChildIndex #

Patch Set 8 : #

Messages

Total messages: 31 (20 generated)
dgn
PTAL. Tests TBD
4 years, 2 months ago (2016-10-20 17:19:08 UTC) #2
Bernhard Bauer
lgtm
4 years, 2 months ago (2016-10-20 17:44:03 UTC) #3
dgn
PTAL, I had to change TreeNode, to be able to see when the requested child ...
4 years, 2 months ago (2016-10-21 17:38:35 UTC) #9
Bernhard Bauer
https://codereview.chromium.org/2434263002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsConfig.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsConfig.java (right): https://codereview.chromium.org/2434263002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsConfig.java#newcode44 chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsConfig.java:44: if (sTestFeatureList == null) return ChromeFeatureList.isEnabled(feature); Yeah, it would ...
4 years, 2 months ago (2016-10-22 16:10:44 UTC) #12
dgn
PTAL https://codereview.chromium.org/2434263002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsConfig.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsConfig.java (right): https://codereview.chromium.org/2434263002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsConfig.java#newcode44 chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsConfig.java:44: if (sTestFeatureList == null) return ChromeFeatureList.isEnabled(feature); On 2016/10/22 ...
4 years, 1 month ago (2016-10-24 13:41:41 UTC) #15
Bernhard Bauer
https://codereview.chromium.org/2434263002/diff/40001/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java File chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java (right): https://codereview.chromium.org/2434263002/diff/40001/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java#newcode877 chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java:877: assertEquals(RecyclerView.NO_POSITION, mAdapter.getFooterPosition()); On 2016/10/24 13:41:41, dgn wrote: > On ...
4 years, 1 month ago (2016-10-24 13:55:58 UTC) #16
dgn
PTAL
4 years, 1 month ago (2016-10-24 16:10:57 UTC) #23
Bernhard Bauer
lgtm
4 years, 1 month ago (2016-10-24 16:13:28 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2434263002/140001
4 years, 1 month ago (2016-10-24 16:19:39 UTC) #27
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 1 month ago (2016-10-24 16:59:51 UTC) #29
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 17:20:09 UTC) #31
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/372bfbd50af98d1b80ff215fb8040b530db54196
Cr-Commit-Position: refs/heads/master@{#427090}

Powered by Google App Engine
This is Rietveld 408576698