webrtc/test/configurable_frame_size_encoder.h - Issue 2434073003: Extract bitrate allocation of spatial/temporal layers out of codec impl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/test/configurable_frame_size_encoder.h

Issue 2434073003: Extract bitrate allocation of spatial/temporal layers out of codec impl. (Closed)

Patch Set: Addressed comments. Moved VideoCodec creation to factory class. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/test/configurable_frame_size_encoder.h

diff --git a/webrtc/test/configurable_frame_size_encoder.h b/webrtc/test/configurable_frame_size_encoder.h

index d269441667baba458c36a88ceecf8a4bdfbfe5bb..a3820baf7e5bdc4e9012fa3f707ceb127b2e5954 100644

--- a/webrtc/test/configurable_frame_size_encoder.h

+++ b/webrtc/test/configurable_frame_size_encoder.h

@@ -39,7 +39,8 @@ class ConfigurableFrameSizeEncoder : public VideoEncoder {

int32_t SetChannelParameters(uint32_t packet_loss, int64_t rtt) override;

- int32_t SetRates(uint32_t new_bit_rate, uint32_t frame_rate) override;

+ int32_t SetRateAllocation(const BitrateAllocation& allocation,

+ uint32_t framerate) override;

int32_t SetPeriodicKeyFrames(bool enable) override;