webrtc/modules/video_coding/video_coding_impl.cc - Issue 2434073003: Extract bitrate allocation of spatial/temporal layers out of codec impl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/video_coding_impl.cc

Issue 2434073003: Extract bitrate allocation of spatial/temporal layers out of codec impl. (Closed)

Patch Set: Addressed comments. Moved VideoCodec creation to factory class. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/video_coding/video_coding_impl.cc

diff --git a/webrtc/modules/video_coding/video_coding_impl.cc b/webrtc/modules/video_coding/video_coding_impl.cc

index 2f709b610c1453a6e8fc9415042189a9f03ddae2..07ac5e8c3e32dc4d21e994a1a56957ff28538acb 100644

--- a/webrtc/modules/video_coding/video_coding_impl.cc

+++ b/webrtc/modules/video_coding/video_coding_impl.cc

@@ -126,7 +126,7 @@ class VideoCodingModuleImpl : public VideoCodingModule {

int32_t SetChannelParameters(uint32_t target_bitrate, // bits/s.

uint8_t lossRate,

int64_t rtt) override {

- return sender_.SetChannelParameters(target_bitrate, lossRate, rtt);

+ return sender_.SetChannelParameters(target_bitrate, lossRate, rtt, nullptr);

}

int32_t RegisterProtectionCallback(