Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Unified Diff: webrtc/modules/video_coding/generic_encoder.cc

Issue 2434073003: Extract bitrate allocation of spatial/temporal layers out of codec impl. (Closed)
Patch Set: Addressed comments. Moved VideoCodec creation to factory class. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/generic_encoder.cc
diff --git a/webrtc/modules/video_coding/generic_encoder.cc b/webrtc/modules/video_coding/generic_encoder.cc
index acef556b2425d4429b22eb73d5b77dd25f211eab..3b1c612c07c3be0494a10f5f6eb6837bcc88f100 100644
--- a/webrtc/modules/video_coding/generic_encoder.cc
+++ b/webrtc/modules/video_coding/generic_encoder.cc
@@ -28,7 +28,7 @@ VCMGenericEncoder::VCMGenericEncoder(
: encoder_(encoder),
vcm_encoded_frame_callback_(encoded_frame_callback),
internal_source_(internal_source),
- encoder_params_({0, 0, 0, 0}),
+ encoder_params_({BitrateAllocation(), 0, 0, 0}),
is_screenshare_(false) {}
VCMGenericEncoder::~VCMGenericEncoder() {}
@@ -93,8 +93,7 @@ void VCMGenericEncoder::SetEncoderParameters(const EncoderParameters& params) {
if (channel_parameters_have_changed)
encoder_->SetChannelParameters(params.loss_rate, params.rtt);
if (rates_have_changed) {
- uint32_t target_bitrate_kbps = (params.target_bitrate + 500) / 1000;
- encoder_->SetRates(target_bitrate_kbps, params.input_frame_rate);
+ encoder_->SetRateAllocation(params.target_bitrate, params.input_frame_rate);
}
}

Powered by Google App Engine
This is Rietveld 408576698