Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2588)

Unified Diff: webrtc/modules/video_coding/include/video_bitrate_allocator_factory.h

Issue 2434073003: Extract bitrate allocation of spatial/temporal layers out of codec impl. (Closed)
Patch Set: Fixed sign mismatch Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/include/video_bitrate_allocator_factory.h
diff --git a/webrtc/test/fake_videorenderer.h b/webrtc/modules/video_coding/include/video_bitrate_allocator_factory.h
similarity index 51%
copy from webrtc/test/fake_videorenderer.h
copy to webrtc/modules/video_coding/include/video_bitrate_allocator_factory.h
index ff43fc09e475a03dcd1ff9dcef8b934dd03e105d..2a8d8f8d8bb4a8231d484df226f72c110443ee7d 100644
--- a/webrtc/test/fake_videorenderer.h
+++ b/webrtc/modules/video_coding/include/video_bitrate_allocator_factory.h
@@ -8,21 +8,22 @@
* be found in the AUTHORS file in the root of the source tree.
*/
-#ifndef WEBRTC_TEST_FAKE_VIDEORENDERER_H_
-#define WEBRTC_TEST_FAKE_VIDEORENDERER_H_
+#ifndef WEBRTC_MODULES_VIDEO_CODING_INCLUDE_VIDEO_BITRATE_ALLOCATOR_FACTORY_H_
+#define WEBRTC_MODULES_VIDEO_CODING_INCLUDE_VIDEO_BITRATE_ALLOCATOR_FACTORY_H_
-#include "webrtc/media/base/videosinkinterface.h"
-#include "webrtc/video_frame.h"
+#include <memory>
namespace webrtc {
-namespace test {
-class FakeVideoRenderer : public rtc::VideoSinkInterface<webrtc::VideoFrame> {
+class VideoBitrateAllocator;
+struct VideoCodec;
+
+class VideoBitrateAllocatorFactory {
perkj_webrtc 2016/10/27 12:57:31 Please add documementation.
sprang_webrtc 2016/11/01 18:03:16 Done.
public:
- void OnFrame(const webrtc::VideoFrame& frame) override {}
+ static std::unique_ptr<VideoBitrateAllocator> GetBitrateAllocator(
+ VideoCodec* codec);
};
-} // namespace test
} // namespace webrtc
-#endif // WEBRTC_TEST_FAKE_VIDEORENDERER_H_
+#endif // WEBRTC_MODULES_VIDEO_CODING_INCLUDE_VIDEO_BITRATE_ALLOCATOR_FACTORY_H_

Powered by Google App Engine
This is Rietveld 408576698