Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1550)

Issue 2434043002: Reland of Move bitstream parser to more appropriate directory. (Closed)

Created:
4 years, 2 months ago by kthelgason
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Move bitstream parser to more appropriate directory. (patchset #1 id:1 of https://codereview.webrtc.org/2430353004/ ) Reason for revert: Internal project has been fixed Original issue's description: > Revert of Move bitstream parser to more appropriate directory. (patchset #4 id:60001 of https://codereview.webrtc.org/2370853005/ ) > > Reason for revert: > Breaks internal project > > Original issue's description: > > Move current bitstream parser to more appropriate directory. > > > > This CL groups together the code that has to do with parsing H264 bitstreams. > > This code logically belongs together, and having it in the same directory not > > only simplifies things from a project structure perspective, but also makes it > > easier to refactor out common parts incrementally. > > An added benefit is that this simplifies modular compilation, where for example > > one would like a build of WebRTC without the H264 codec-specific parts. > > > > BUG=webrtc:6338 > > > > Committed: https://crrev.com/cc6817e9ce4a5ffc73efb660cf0368afbc7d9a4f > > Cr-Commit-Position: refs/heads/master@{#14684} > > TBR=magjed@webrtc.org,stefan@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6338 > > Committed: https://crrev.com/f04f14e772f803de39f8a6128e5157127cd35103 > Cr-Commit-Position: refs/heads/master@{#14685} TBR=magjed@webrtc.org,stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true BUG=webrtc:6338

Patch Set 1 #

Patch Set 2 : remove moved files from gyp file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -427 lines) Patch
M webrtc/api/android/jni/androidmediaencoder_jni.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_video/BUILD.gn View 1 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/common_video/common_video.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + webrtc/common_video/h264/h264_bitstream_parser.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/common_video/h264/h264_bitstream_parser.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/common_video/h264/h264_bitstream_parser_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/modules/video_coding/utility/h264_bitstream_parser.h View 1 chunk +0 lines, -59 lines 0 comments Download
D webrtc/modules/video_coding/utility/h264_bitstream_parser.cc View 1 chunk +0 lines, -293 lines 0 comments Download
D webrtc/modules/video_coding/utility/h264_bitstream_parser_unittest.cc View 1 chunk +0 lines, -62 lines 0 comments Download
M webrtc/modules/video_coding/utility/video_coding_utility.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
kthelgason
Created Reland of Move bitstream parser to more appropriate directory.
4 years, 2 months ago (2016-10-19 17:58:27 UTC) #1
magjed_webrtc
lgtm
4 years, 2 months ago (2016-10-20 14:07:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2434043002/260001
4 years, 1 month ago (2016-10-26 09:48:11 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:260001)
4 years, 1 month ago (2016-10-26 09:48:19 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 09:48:31 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b906172e02e695ecd302b6d78cb05ddd2643e6f9
Cr-Commit-Position: refs/heads/master@{#14783}

Powered by Google App Engine
This is Rietveld 408576698