Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2433503002: Remove DesktopRegion parameter from DesktopCapturer::Capture (Closed)

Created:
4 years, 2 months ago by Hzj_jie
Modified:
4 years, 2 months ago
Reviewers:
Sergey Ulanov
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove DesktopRegion parameter from DesktopCapturer::Capture BUG=https://bugs.chromium.org/p/webrtc/issues/detail?id=6513 Committed: https://crrev.com/249beee124254cd175622a8b9261a2cfa24cad9b Cr-Commit-Position: refs/heads/master@{#14676}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Resolve review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -18 lines) Patch
M webrtc/modules/desktop_capture/cropping_window_capturer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/desktop_capture/desktop_capturer.h View 1 2 chunks +6 lines, -8 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_mac_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_mock_objects.h View 1 1 chunk +1 line, -6 lines 0 comments Download
M webrtc/modules/desktop_capture/window_capturer_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
Hzj_jie
4 years, 2 months ago (2016-10-18 23:01:11 UTC) #4
Sergey Ulanov
https://codereview.chromium.org/2433503002/diff/20001/webrtc/modules/desktop_capture/desktop_capturer.h File webrtc/modules/desktop_capture/desktop_capturer.h (right): https://codereview.chromium.org/2433503002/diff/20001/webrtc/modules/desktop_capture/desktop_capturer.h#newcode71 webrtc/modules/desktop_capture/desktop_capturer.h:71: virtual void Capture() { CaptureFrame(); } I think CaptureFrame() ...
4 years, 2 months ago (2016-10-18 23:37:10 UTC) #5
Hzj_jie
https://codereview.chromium.org/2433503002/diff/20001/webrtc/modules/desktop_capture/desktop_capturer.h File webrtc/modules/desktop_capture/desktop_capturer.h (right): https://codereview.chromium.org/2433503002/diff/20001/webrtc/modules/desktop_capture/desktop_capturer.h#newcode71 webrtc/modules/desktop_capture/desktop_capturer.h:71: virtual void Capture() { CaptureFrame(); } On 2016/10/18 23:37:10, ...
4 years, 2 months ago (2016-10-19 00:49:17 UTC) #7
Sergey Ulanov
lgtm
4 years, 2 months ago (2016-10-19 05:23:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2433503002/60001
4 years, 2 months ago (2016-10-19 05:43:34 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 2 months ago (2016-10-19 06:13:33 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-19 06:13:44 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/249beee124254cd175622a8b9261a2cfa24cad9b
Cr-Commit-Position: refs/heads/master@{#14676}

Powered by Google App Engine
This is Rietveld 408576698