Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2433373003: Add fuzzer for FlexfecSender. (Closed)

Created:
4 years, 2 months ago by brandtr
Modified:
4 years, 1 month ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add fuzzer for FlexfecSender. BUG=webrtc:5654 NOTRY=true Committed: https://crrev.com/554becd7bf545e06075973f544cbbefddc044e23 Cr-Commit-Position: refs/heads/master@{#14937}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase fix. #

Patch Set 4 : Rebase. #

Total comments: 2

Patch Set 5 : Feedback response 1 + always set media ssrc correct. #

Total comments: 1

Patch Set 6 : Rebase. #

Patch Set 7 : Rebase. #

Patch Set 8 : Rebase fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -0 lines) Patch
M webrtc/test/fuzzers/BUILD.gn View 1 2 3 4 5 1 chunk +10 lines, -0 lines 0 comments Download
A webrtc/test/fuzzers/flexfec_sender_fuzzer.cc View 1 2 3 4 5 6 7 1 chunk +68 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (7 generated)
brandtr
And this one too!
4 years, 2 months ago (2016-10-20 13:28:09 UTC) #2
brandtr
Rebase.
4 years, 1 month ago (2016-10-24 12:52:51 UTC) #3
brandtr
Rebase.
4 years, 1 month ago (2016-10-28 07:38:39 UTC) #5
stefan-webrtc
lgtm % nit https://codereview.webrtc.org/2433373003/diff/60001/webrtc/test/fuzzers/flexfec_sender_fuzzer.cc File webrtc/test/fuzzers/flexfec_sender_fuzzer.cc (right): https://codereview.webrtc.org/2433373003/diff/60001/webrtc/test/fuzzers/flexfec_sender_fuzzer.cc#newcode13 webrtc/test/fuzzers/flexfec_sender_fuzzer.cc:13: #include "webrtc/base/checks.h" Not used.
4 years, 1 month ago (2016-10-31 09:18:15 UTC) #6
brandtr
https://codereview.webrtc.org/2433373003/diff/60001/webrtc/test/fuzzers/flexfec_sender_fuzzer.cc File webrtc/test/fuzzers/flexfec_sender_fuzzer.cc (right): https://codereview.webrtc.org/2433373003/diff/60001/webrtc/test/fuzzers/flexfec_sender_fuzzer.cc#newcode13 webrtc/test/fuzzers/flexfec_sender_fuzzer.cc:13: #include "webrtc/base/checks.h" On 2016/10/31 09:18:15, stefan-webrtc (holmer) wrote: > ...
4 years, 1 month ago (2016-10-31 11:07:32 UTC) #8
brandtr
Rebase.
4 years, 1 month ago (2016-11-02 10:31:14 UTC) #9
brandtr
Rebase.
4 years, 1 month ago (2016-11-03 15:32:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2433373003/160001
4 years, 1 month ago (2016-11-07 06:41:37 UTC) #13
commit-bot: I haz the power
Committed patchset #8 (id:160001)
4 years, 1 month ago (2016-11-07 06:45:18 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 06:45:27 UTC) #17
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/554becd7bf545e06075973f544cbbefddc044e23
Cr-Commit-Position: refs/heads/master@{#14937}

Powered by Google App Engine
This is Rietveld 408576698