Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: webrtc/modules/audio_processing/echo_cancellation_impl.h

Issue 2433153003: New statistics interface for APM (Closed)
Patch Set: More comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_processing/echo_cancellation_impl.h
diff --git a/webrtc/modules/audio_processing/echo_cancellation_impl.h b/webrtc/modules/audio_processing/echo_cancellation_impl.h
index bab5e54f4bd4b7f044765e7850ebb80b01ce2202..608e2f7eace70797ee68ecf715b8faa95c38a705 100644
--- a/webrtc/modules/audio_processing/echo_cancellation_impl.h
+++ b/webrtc/modules/audio_processing/echo_cancellation_impl.h
@@ -57,6 +57,20 @@ class EchoCancellationImpl : public EchoCancellation {
// Returns the system delay of the first AEC component.
int GetSystemDelayInSamples() const;
+ // Enable logging of various AEC statistics.
+ int enable_metrics(bool enable) override;
+
+ // Provides various statistics about the AEC.
+ int GetMetrics(Metrics* metrics) override;
+
+ // Enable logging of delay metrics.
+ int enable_delay_logging(bool enable) override;
+
+ // Provides delay metrics.
+ int GetDelayMetrics(int* median,
+ int* std,
+ float* fraction_poor_delays) override;
+
private:
class Canceller;
struct StreamProperties;
@@ -66,16 +80,10 @@ class EchoCancellationImpl : public EchoCancellation {
int enable_drift_compensation(bool enable) override;
void set_stream_drift_samples(int drift) override;
int set_suppression_level(SuppressionLevel level) override;
- int enable_metrics(bool enable) override;
bool are_metrics_enabled() const override;
bool stream_has_echo() const override;
- int GetMetrics(Metrics* metrics) override;
- int enable_delay_logging(bool enable) override;
bool is_delay_logging_enabled() const override;
int GetDelayMetrics(int* median, int* std) override;
- int GetDelayMetrics(int* median,
- int* std,
- float* fraction_poor_delays) override;
struct AecCore* aec_core() const override;

Powered by Google App Engine
This is Rietveld 408576698