Add rtc::Optional equality/unequality comparisions with object

Add to rtc::Optional equality/unequality comparisions with object

BUG=None

Committed: https://crrev.com/e0370601612275628850e6a06ddf5a3e3e77a2ee
Cr-Commit-Position: refs/heads/master@{#14690}

[danilchap, 2016-10-19 11:09:33]

danilchap@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[ossu, 2016-10-19 11:14:38]

ossu@webrtc.org changed reviewers:
+ ossu@webrtc.org

[ossu, 2016-10-19 11:14:39]

Hey! This looks a lot like a CL I did a while back, but which got sidetracked
(https://codereview.webrtc.org/2072713002/). 

I really like seeing this get implemented!

[kwiberg-webrtc, 2016-10-19 11:16:42]

lgtm with a minor nit

https://codereview.webrtc.org/2432393002/diff/1/webrtc/base/optional.h
File webrtc/base/optional.h (right):

https://codereview.webrtc.org/2432393002/diff/1/webrtc/base/optional.h#newcod...
webrtc/base/optional.h:257: }
Maybe do all the operator== before the operator!= ?

[danilchap, 2016-10-19 11:21:31]

On 2016/10/19 11:14:39, ossu wrote:
> Hey! This looks a lot like a CL I did a while back, but which got sidetracked
> (https://codereview.webrtc.org/2072713002/). 
> 

Yes, I've seen that CL. because of it I've added you to CC but excluded your
changes to the constructors.
I implemented comparison slightly differently (to your and chromium
implementations) because of a line in the spec:
"The values are compared (using the corresponding operator of T) ..."

[danilchap, 2016-10-19 11:23:52]

https://codereview.webrtc.org/2432393002/diff/1/webrtc/base/optional.h
File webrtc/base/optional.h (right):

https://codereview.webrtc.org/2432393002/diff/1/webrtc/base/optional.h#newcod...
webrtc/base/optional.h:257: }
On 2016/10/19 11:16:42, kwiberg-webrtc wrote:
> Maybe do all the operator== before the operator!= ?

Good point. Done.

[ossu, 2016-10-19 11:27:11]

On 2016/10/19 11:21:31, danilchap wrote:
> On 2016/10/19 11:14:39, ossu wrote:
> > Hey! This looks a lot like a CL I did a while back, but which got
sidetracked
> > (https://codereview.webrtc.org/2072713002/). 
> > 
> 
> Yes, I've seen that CL. because of it I've added you to CC but excluded your
> changes to the constructors.
> I implemented comparison slightly differently (to your and chromium
> implementations) because of a line in the spec:
> "The values are compared (using the corresponding operator of T) ..."

Ah, that explains why I was CC:ed.
Your implementation of the operators seem more correct than mine as well. I'll
give you an LGTM even though you don't need it. :)

[danilchap, 2016-10-19 15:12:50]

The CQ bit was checked by danilchap@webrtc.org

[danilchap, 2016-10-19 15:12:50]

The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2432393002/#ps20001 (title:
"Feedback")

[commit-bot: I haz the power, 2016-10-19 15:12:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-19 17:13:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 17:13:33]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[danilchap, 2016-10-20 07:42:16]

The CQ bit was checked by danilchap@webrtc.org

[commit-bot: I haz the power, 2016-10-20 07:42:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-20 07:58:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-20 07:58:35]

Description was changed from

==========
Add to rtc::Optional equality/unequality comparisions with object

BUG=None
==========

to

==========
Add to rtc::Optional equality/unequality comparisions with object

BUG=None

Committed: https://crrev.com/e0370601612275628850e6a06ddf5a3e3e77a2ee
Cr-Commit-Position: refs/heads/master@{#14690}
==========

[commit-bot: I haz the power, 2016-10-20 07:58:36]

Patchset 2 (id:??) landed as
https://crrev.com/e0370601612275628850e6a06ddf5a3e3e77a2ee
Cr-Commit-Position: refs/heads/master@{#14690}