Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: webrtc/sdk/BUILD.gn

Issue 2431603002: Prevent stripping of C interfaces in framework (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/sdk/BUILD.gn
diff --git a/webrtc/sdk/BUILD.gn b/webrtc/sdk/BUILD.gn
index 755390c38c2e0a935513c3096dbe9ebd5a0a9d65..7b2072698d83949395e77ed6cc5c2a6baeccafbe 100644
--- a/webrtc/sdk/BUILD.gn
+++ b/webrtc/sdk/BUILD.gn
@@ -252,12 +252,24 @@ if (is_ios || (is_mac && mac_deployment_target == "10.7")) {
"objc/Framework/Headers/WebRTC/UIDevice+RTCDevice.h",
"objc/Framework/Headers/WebRTC/WebRTC.h",
]
+
+ # Slightly hacky, but we need to re-declare files here that are C
tkchin_webrtc 2016/10/19 00:26:26 use -all_load like the ios framework?
+ # interfaces because otherwise they will be dead-stripped during
+ # linking (ObjC classes cannot be dead-stripped). We might consider
+ # just only using ObjC interfaces.
+ c_interfaces = [
+ "objc/Framework/Classes/RTCFieldTrials.mm",
+ "objc/Framework/Classes/RTCLogging.mm",
+ "objc/Framework/Classes/RTCMetrics.mm",
+ "objc/Framework/Classes/RTCSSLAdapter.mm",
+ "objc/Framework/Classes/RTCTracing.mm",
+ ]
if (is_mac) {
mac_framework_bundle("rtc_sdk_framework_objc") {
info_plist = "objc/Framework/Info.plist"
output_name = "WebRTC"
- sources = common_objc_headers +
+ sources = common_objc_headers + c_interfaces +
[ "objc/Framework/Headers/WebRTC/RTCNSGLVideoView.h" ]
if (!build_with_chromium) {
@@ -297,7 +309,7 @@ if (is_ios || (is_mac && mac_deployment_target == "10.7")) {
info_plist = "objc/Framework/Info.plist"
output_name = "WebRTC"
- sources = common_objc_headers
+ sources = common_objc_headers + c_interfaces
public_headers = common_objc_headers
if (!build_with_chromium) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698