Prevent stripping of C interfaces in framework

Prevent stripping of C interfaces in framework

We need to redaclare certain interfaces in the GN build files for the
macOS and iOS framework targets to prevent those symbols being stripped
by the linker.

BUG=webrtc:6434
Committed: https://crrev.com/725e2121adc54a874a11eebad3a194edea11202f
Cr-Commit-Position: refs/heads/master@{#14691}

[kthelgason, 2016-10-18 08:14:30]

kthelgason@webrtc.org changed reviewers:
+ kjellander@webrtc.org, tkchin@webrtc.org

[kthelgason, 2016-10-18 08:14:31]

PTAL

[kjellander_webrtc, 2016-10-18 11:23:20]

lgtm but wait for Zeke's approval as well.

[tkchin_webrtc, 2016-10-19 00:26:26]

https://codereview.webrtc.org/2431603002/diff/1/webrtc/sdk/BUILD.gn
File webrtc/sdk/BUILD.gn (right):

https://codereview.webrtc.org/2431603002/diff/1/webrtc/sdk/BUILD.gn#newcode256
webrtc/sdk/BUILD.gn:256: # Slightly hacky, but we need to re-declare files here
that are C
use -all_load like the ios framework?

[kthelgason, 2016-10-19 08:24:44]

On 2016/10/19 00:26:26, tkchin_webrtc wrote:
> https://codereview.webrtc.org/2431603002/diff/1/webrtc/sdk/BUILD.gn
> File webrtc/sdk/BUILD.gn (right):
> 
> https://codereview.webrtc.org/2431603002/diff/1/webrtc/sdk/BUILD.gn#newcode256
> webrtc/sdk/BUILD.gn:256: # Slightly hacky, but we need to re-declare files
here
> that are C
> use -all_load like the ios framework?

Thanks Zeke, I didn't know what that did. Fixed.

[tkchin_webrtc, 2016-10-19 22:33:23]

On 2016/10/19 08:24:44, kthelgason wrote:
> On 2016/10/19 00:26:26, tkchin_webrtc wrote:
> > https://codereview.webrtc.org/2431603002/diff/1/webrtc/sdk/BUILD.gn
> > File webrtc/sdk/BUILD.gn (right):
> > 
> >
https://codereview.webrtc.org/2431603002/diff/1/webrtc/sdk/BUILD.gn#newcode256
> > webrtc/sdk/BUILD.gn:256: # Slightly hacky, but we need to re-declare files
> here
> > that are C
> > use -all_load like the ios framework?
> 
> Thanks Zeke, I didn't know what that did. Fixed.

lgtm

[kthelgason, 2016-10-20 07:51:42]

The CQ bit was checked by kthelgason@webrtc.org

[kthelgason, 2016-10-20 07:51:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2431603002/#ps20001 (title:
"add all-load flag")

[commit-bot: I haz the power, 2016-10-20 07:51:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-20 08:31:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-20 08:31:54]

Description was changed from

==========
Prevent stripping of C interfaces in framework

We need to redaclare certain interfaces in the GN build files for the
macOS and iOS framework targets to prevent those symbols being stripped
by the linker.

BUG=webrtc:6434
==========

to

==========
Prevent stripping of C interfaces in framework

We need to redaclare certain interfaces in the GN build files for the
macOS and iOS framework targets to prevent those symbols being stripped
by the linker.

BUG=webrtc:6434

Committed: https://crrev.com/725e2121adc54a874a11eebad3a194edea11202f
Cr-Commit-Position: refs/heads/master@{#14691}
==========

[commit-bot: I haz the power, 2016-10-20 08:31:55]

Patchset 2 (id:??) landed as
https://crrev.com/725e2121adc54a874a11eebad3a194edea11202f
Cr-Commit-Position: refs/heads/master@{#14691}