Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2431473004:
Fix some flaky tests by using longer timeout and/or fake clock. (Closed)
|
Created:
4 years, 2 months ago by honghaiz3 Modified:
4 years, 2 months ago Reviewers:
Taylor Brandstetter CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionFix some flaky tests by using longer timeout and/or fake clock.
Also use const variables for timeout values.
BUG=webrtc:6500
R=deadbeef@webrtc.org
Committed: https://crrev.com/161a586b457bf58402ac1e2d233988956e329ea8
Cr-Commit-Position: refs/heads/master@{#14711}
Patch Set 1 : . #
Messages
Total messages: 17 (11 generated)
Description was changed from ========== Fix some flaky tests by using longer timeout and/or fake clock. BUG=webrtc:6500 ========== to ========== Fix some flaky tests by using longer timeout and/or fake clock. Also used const variables for timeout values. BUG=webrtc:6500 ==========
Patchset #1 (id:1) has been deleted
Description was changed from ========== Fix some flaky tests by using longer timeout and/or fake clock. Also used const variables for timeout values. BUG=webrtc:6500 ========== to ========== Fix some flaky tests by using longer timeout and/or fake clock. Also use const variables for timeout values. BUG=webrtc:6500 ==========
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
deadbeef@webrtc.org changed reviewers: + deadbeef@webrtc.org
lgtm. But FYI, it looks like the NAT matrix test will still need to be updated.
The CQ bit was checked by honghaiz@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_clang_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_compile_mips_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_compile_x64_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_compile_x86_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_compile_x86_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_gyp_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_arm on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_asan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_compile_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_gyp_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_libfuzzer_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_msan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_tsan2 on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_ubsan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_ubsan_vptr on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) presubmit on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
On 2016/10/20 01:31:30, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) > android_clang_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) > android_compile_mips_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build > URL) > android_compile_x64_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build > URL) > android_compile_x86_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build > URL) > android_compile_x86_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build > URL) > android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) > android_gyp_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) > android_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) > linux_arm on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) > linux_asan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) > linux_compile_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) > linux_gyp_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) > linux_libfuzzer_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) > linux_msan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) > linux_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) > linux_tsan2 on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) > linux_ubsan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) > linux_ubsan_vptr on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) > presubmit on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) Will leave changing the constant in the Matrix test in a separate CL.
The CQ bit was checked by honghaiz@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Description was changed from ========== Fix some flaky tests by using longer timeout and/or fake clock. Also use const variables for timeout values. BUG=webrtc:6500 ========== to ========== Fix some flaky tests by using longer timeout and/or fake clock. Also use const variables for timeout values. BUG=webrtc:6500 R=deadbeef@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/161a586b457bf58402ac1e2d2... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:60001) manually as 161a586b457bf58402ac1e2d233988956e329ea8 (presubmit successful).
Message was sent while issue was closed.
Description was changed from ========== Fix some flaky tests by using longer timeout and/or fake clock. Also use const variables for timeout values. BUG=webrtc:6500 R=deadbeef@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/161a586b457bf58402ac1e2d2... ========== to ========== Fix some flaky tests by using longer timeout and/or fake clock. Also use const variables for timeout values. BUG=webrtc:6500 R=deadbeef@webrtc.org Committed: https://crrev.com/161a586b457bf58402ac1e2d233988956e329ea8 Cr-Commit-Position: refs/heads/master@{#14711} ========== |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
